qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/30] tcg/loongarch: Add the tcg-target.h file


From: Richard Henderson
Subject: Re: [PATCH 03/30] tcg/loongarch: Add the tcg-target.h file
Date: Mon, 20 Sep 2021 09:25:51 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 9/20/21 9:20 AM, WANG Xuerui wrote:
+ * Copyright (c) 2018 SiFive, Inc

You may have copied too much from the riscv port?  :-)

First of all, thanks for the *extremely* quick review!

As for the copying, I admit that I thought the riscv port generally was doing things the recent and preferred way, so most of the logic are only lightly touched. However the LoongArch is substantially similar to riscv too, so much of the traits expressed here would be the same regardless.

But in such a case of outstanding similarity, should I just drop my "copyright" line? I'm actually okay with dropping if that's the best thing to do.

Yes, your own copyright is the correct thing in this case.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]