qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/30] tcg/loongarch: Add register names, allocation order an


From: WANG Xuerui
Subject: Re: [PATCH 05/30] tcg/loongarch: Add register names, allocation order and input/output sets
Date: Tue, 21 Sep 2021 00:27:07 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0a1

Hi Richard,

On 9/20/21 23:57, Richard Henderson wrote:
On 9/20/21 1:04 AM, WANG Xuerui wrote:
+    /* Argument registers */
+    TCG_REG_A0,
+    TCG_REG_A1,
+    TCG_REG_A2,
+    TCG_REG_A3,
+    TCG_REG_A4,
+    TCG_REG_A5,
+    TCG_REG_A6,
+    TCG_REG_A7,
+};

Generally I'd place the argument registers in reverse usage order.  It means that we'll try to use A7 before A0, which may work to our favor if the called function has less than 8 arguments.
Hmm, is that a trick already employed by other TCG ports? I'll check the code and adjust if that proves beneficial indeed.

But otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]