Re: [PATCH v3 04/30] tcg/loongarch64: Add generated instruction opcodes and encoding helpers

[Philippe Mathieu-Daudé]

On 9/22/21 20:09, WANG Xuerui wrote:
> Signed-off-by: WANG Xuerui <git@xen0n.name>
> Acked-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/loongarch64/tcg-insn-defs.c.inc | 881 ++++++++++++++++++++++++++++
>   1 file changed, 881 insertions(+)
>   create mode 100644 tcg/loongarch64/tcg-insn-defs.c.inc
>
> diff --git a/tcg/loongarch64/tcg-insn-defs.c.inc 
> b/tcg/loongarch64/tcg-insn-defs.c.inc
> new file mode 100644
> index 0000000000..7d73136b1b
> --- /dev/null
> +++ b/tcg/loongarch64/tcg-insn-defs.c.inc
> @@ -0,0 +1,881 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * LoongArch instruction formats, opcodes, and encoders for TCG use.
> + *
> + * Code generated by genqemutcgdefs from
> + * https://github.com/loongson-community/loongarch-opcodes,
> + * from commit 308d38087401eb333063556f027ce0b24d86b416.
> + * DO NOT EDIT.

The generated code ...

> + */
> +
> +typedef enum {
> +    OPC_CLZ_W = 0x00001400,
> +    OPC_CTZ_W = 0x00001c00,
> +    OPC_CLZ_D = 0x00002400,
> +    OPC_CTZ_D = 0x00002c00,
> +    OPC_REVB_2H = 0x00003000,
> +    OPC_REVB_2W = 0x00003800,
> +    OPC_REVB_D = 0x00003c00,
> +    OPC_SEXT_H = 0x00005800,
> +    OPC_SEXT_B = 0x00005c00,
> +    OPC_ADD_W = 0x00100000,
> +    OPC_ADD_D = 0x00108000,
> +    OPC_SUB_W = 0x00110000,
> +    OPC_SUB_D = 0x00118000,
> +    OPC_SLT = 0x00120000,
> +    OPC_SLTU = 0x00128000,
> +    OPC_MASKEQZ = 0x00130000,
> +    OPC_MASKNEZ = 0x00138000,
> +    OPC_NOR = 0x00140000,
> +    OPC_AND = 0x00148000,
> +    OPC_OR = 0x00150000,
> +    OPC_XOR = 0x00158000,
> +    OPC_ORN = 0x00160000,
> +    OPC_ANDN = 0x00168000,
> +    OPC_SLL_W = 0x00170000,
> +    OPC_SRL_W = 0x00178000,
> +    OPC_SRA_W = 0x00180000,
> +    OPC_SLL_D = 0x00188000,
> +    OPC_SRL_D = 0x00190000,
> +    OPC_SRA_D = 0x00198000,
> +    OPC_ROTR_W = 0x001b0000,
> +    OPC_ROTR_D = 0x001b8000,
> +    OPC_MUL_W = 0x001c0000,
> +    OPC_MULH_W = 0x001c8000,
> +    OPC_MULH_WU = 0x001d0000,
> +    OPC_MUL_D = 0x001d8000,
> +    OPC_MULH_D = 0x001e0000,
> +    OPC_MULH_DU = 0x001e8000,
> +    OPC_DIV_W = 0x00200000,
> +    OPC_MOD_W = 0x00208000,
> +    OPC_DIV_WU = 0x00210000,
> +    OPC_MOD_WU = 0x00218000,
> +    OPC_DIV_D = 0x00220000,
> +    OPC_MOD_D = 0x00228000,
> +    OPC_DIV_DU = 0x00230000,
> +    OPC_MOD_DU = 0x00238000,
> +    OPC_SLLI_W = 0x00408000,
> +    OPC_SLLI_D = 0x00410000,
> +    OPC_SRLI_W = 0x00448000,
> +    OPC_SRLI_D = 0x00450000,
> +    OPC_SRAI_W = 0x00488000,
> +    OPC_SRAI_D = 0x00490000,
> +    OPC_ROTRI_W = 0x004c8000,
> +    OPC_ROTRI_D = 0x004d0000,
> +    OPC_BSTRINS_W = 0x00600000,
> +    OPC_BSTRPICK_W = 0x00608000,
> +    OPC_BSTRINS_D = 0x00800000,
> +    OPC_BSTRPICK_D = 0x00c00000,
> +    OPC_SLTI = 0x02000000,
> +    OPC_SLTUI = 0x02400000,
> +    OPC_ADDI_W = 0x02800000,
> +    OPC_ADDI_D = 0x02c00000,
> +    OPC_CU52I_D = 0x03000000,
> +    OPC_ANDI = 0x03400000,
> +    OPC_ORI = 0x03800000,
> +    OPC_XORI = 0x03c00000,
> +    OPC_LU12I_W = 0x14000000,
> +    OPC_CU32I_D = 0x16000000,
> +    OPC_PCADDU2I = 0x18000000,
> +    OPC_PCADDU12I = 0x1c000000,
> +    OPC_PCADDU18I = 0x1e000000,
> +    OPC_LD_B = 0x28000000,
> +    OPC_LD_H = 0x28400000,
> +    OPC_LD_W = 0x28800000,
> +    OPC_LD_D = 0x28c00000,
> +    OPC_ST_B = 0x29000000,
> +    OPC_ST_H = 0x29400000,
> +    OPC_ST_W = 0x29800000,
> +    OPC_ST_D = 0x29c00000,
> +    OPC_LD_BU = 0x2a000000,
> +    OPC_LD_HU = 0x2a400000,
> +    OPC_LD_WU = 0x2a800000,
> +    OPC_DBAR = 0x38720000,
> +    OPC_JIRL = 0x4c000000,
> +    OPC_B = 0x50000000,
> +    OPC_BL = 0x54000000,
> +    OPC_BEQ = 0x58000000,
> +    OPC_BNE = 0x5c000000,
> +    OPC_BGT = 0x60000000,
> +    OPC_BLE = 0x64000000,
> +    OPC_BGTU = 0x68000000,
> +    OPC_BLEU = 0x6c000000,
> +} LoongArchInsn;

... ends here, right? ...

> +
> +static int32_t __attribute__((unused))
> +encode_d_slot(LoongArchInsn opc, uint32_t d)
> +{
> +    return opc | d;
> +}
> +
> +static int32_t __attribute__((unused))
> +encode_dj_slots(LoongArchInsn opc, uint32_t d, uint32_t j)
> +{
> +    return opc | d | j << 5;
> +}
> +
> +static int32_t __attribute__((unused))
> +encode_djk_slots(LoongArchInsn opc, uint32_t d, uint32_t j, uint32_t k)
> +{
> +    return opc | d | j << 5 | k << 10;
> +}
> +
> +static int32_t __attribute__((unused))
> +encode_djkm_slots(LoongArchInsn opc, uint32_t d, uint32_t j, uint32_t k,
> +                  uint32_t m)
> +{
> +    return opc | d | j << 5 | k << 10 | m << 16;
> +}
> +
> +static int32_t __attribute__((unused))
> +encode_dk_slots(LoongArchInsn opc, uint32_t d, uint32_t k)
> +{
> +    return opc | d | k << 10;
> +}
> +
> +static int32_t __attribute__((unused))
> +encode_dj_insn(LoongArchInsn opc, TCGReg d, TCGReg j)
> +{
> +    tcg_debug_assert(d >= 0 && d <= 0x1f);
> +    tcg_debug_assert(j >= 0 && j <= 0x1f);
> +    return encode_dj_slots(opc, d, j);
> +}

... or are these helpers also generated?