qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 04/40] hw/core: Move cpu_common_has_work() to cpu_has_work


From: Richard Henderson
Subject: Re: [PATCH v8 04/40] hw/core: Move cpu_common_has_work() to cpu_has_work()
Date: Sun, 26 Sep 2021 19:58:25 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 9/26/21 6:26 PM, Philippe Mathieu-Daudé wrote:
cpu_class_init() always register cpu_common_has_work() as
CPUClass::has_work() handler, so the assertion check in
cpu_has_work() is pointless.
Since cpu_common_has_work() simply returns 'false', we can
inline it in cpu_has_work(), improving the function readability.

Suggested-by: Richard Henderson<richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
  hw/core/cpu-common.c | 6 ------
  softmmu/cpus.c       | 6 ++++--
  2 files changed, 4 insertions(+), 8 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]