Re: [PATCH v11 11/16] target/riscv: Add orc.b instruction for Zbb, remov

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v11 11/16] target/riscv: Add orc.b instruction for Zbb, remov

From:	Richard Henderson
Subject:	Re: [PATCH v11 11/16] target/riscv: Add orc.b instruction for Zbb, removing gorc/gorci
Date:	Tue, 28 Sep 2021 14:45:00 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 9/28/21 11:45 AM, Philipp Tomsich wrote:

The dup_const macro is returning an unsigned long long, which probably
should be fixed on the tcg.h-level instead of forcing a cast to target_long
at the call site.

No, dup_const is first and primarily for vector support, and therefore must return a64-bit constant.

Or should we introduce a dup_const_tl?


Maybe.  I guess that could be a bit better than the cast.


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v11 04/16] target/riscv: Add x-zba, x-zbb, x-zbc and x-zbs properties, (continued)
- [PATCH v11 04/16] target/riscv: Add x-zba, x-zbb, x-zbc and x-zbs properties, Philipp Tomsich, 2021/09/11
- [PATCH v11 14/16] target/riscv: Add zext.h instructions to Zbb, removing pack/packu/packh, Philipp Tomsich, 2021/09/11
- [PATCH v11 03/16] target/riscv: clwz must ignore high bits (use shift-left & changed logic), Philipp Tomsich, 2021/09/11
  - Re: [PATCH v11 03/16] target/riscv: clwz must ignore high bits (use shift-left & changed logic), LIU Zhiwei, 2021/09/14
    - Re: [PATCH v11 03/16] target/riscv: clwz must ignore high bits (use shift-left & changed logic), Philipp Tomsich, 2021/09/14
    - Re: [PATCH v11 03/16] target/riscv: clwz must ignore high bits (use shift-left & changed logic), LIU Zhiwei, 2021/09/15
- [PATCH v11 09/16] target/riscv: Add instructions of the Zbc-extension, Philipp Tomsich, 2021/09/11
- [PATCH v11 11/16] target/riscv: Add orc.b instruction for Zbb, removing gorc/gorci, Philipp Tomsich, 2021/09/11
  - Re: [PATCH v11 11/16] target/riscv: Add orc.b instruction for Zbb, removing gorc/gorci, Alistair Francis, 2021/09/28
    - Re: [PATCH v11 11/16] target/riscv: Add orc.b instruction for Zbb, removing gorc/gorci, Philipp Tomsich, 2021/09/28
    - Re: [PATCH v11 11/16] target/riscv: Add orc.b instruction for Zbb, removing gorc/gorci, Richard Henderson <=
    - Re: [PATCH v11 11/16] target/riscv: Add orc.b instruction for Zbb, removing gorc/gorci, Philipp Tomsich, 2021/09/28
    - Re: [PATCH v11 11/16] target/riscv: Add orc.b instruction for Zbb, removing gorc/gorci, Philipp Tomsich, 2021/09/28
- [PATCH v11 12/16] target/riscv: Add a REQUIRE_32BIT macro, Philipp Tomsich, 2021/09/11
- [PATCH v11 16/16] disas/riscv: Add Zb[abcs] instructions, Philipp Tomsich, 2021/09/11
- [PATCH v11 08/16] target/riscv: Reassign instructions to the Zbs-extension, Philipp Tomsich, 2021/09/11
- [PATCH v11 07/16] target/riscv: Remove shift-one instructions (proposed Zbo in pre-0.93 draft-B), Philipp Tomsich, 2021/09/11
- Re: [PATCH v11 00/16] target/riscv: Update QEmu for Zb[abcs] 1.0.0, Philipp Tomsich, 2021/09/23
  - Re: [PATCH v11 00/16] target/riscv: Update QEmu for Zb[abcs] 1.0.0, Alistair Francis, 2021/09/23
- Re: [PATCH v11 00/16] target/riscv: Update QEmu for Zb[abcs] 1.0.0, Vineet Gupta, 2021/09/27
  - Re: [PATCH v11 00/16] target/riscv: Update QEmu for Zb[abcs] 1.0.0, Jim Wilson, 2021/09/27

Prev by Date: Re: Emulation of IOT hardware
Next by Date: Re: [PATCH v11 11/16] target/riscv: Add orc.b instruction for Zbb, removing gorc/gorci
Previous by thread: Re: [PATCH v11 11/16] target/riscv: Add orc.b instruction for Zbb, removing gorc/gorci
Next by thread: Re: [PATCH v11 11/16] target/riscv: Add orc.b instruction for Zbb, removing gorc/gorci
Index(es):
- Date
- Thread