Re: [PATCH v2 1/1] hw/riscv: shakti_c: Mark as not user creatable

[Bin Meng]

On Wed, Sep 29, 2021 at 7:30 AM Alistair Francis
<alistair.francis@opensource.wdc.com> wrote:
>
> From: Alistair Francis <alistair.francis@wdc.com>
>
> Mark the shakti_c machine as not user creatable.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/639
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>  hw/riscv/shakti_c.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/hw/riscv/shakti_c.c b/hw/riscv/shakti_c.c
> index 2f084d3c8d..e7cd3bdfb4 100644
> --- a/hw/riscv/shakti_c.c
> +++ b/hw/riscv/shakti_c.c
> @@ -150,6 +150,12 @@ static void shakti_c_soc_class_init(ObjectClass *klass, 
> void *data)
>  {
>      DeviceClass *dc = DEVICE_CLASS(klass);
>      dc->realize = shakti_c_soc_state_realize;
> +    /* Reasons:

nits: the multi-line comment format should use:

/*
 *
 */

> +     *     - Creates CPUS in riscv_hart_realize(), and can create unintended
> +     *       CPUs
> +     *     - Uses serial_hds in realize function, thus can't be used twice
> +     */
> +    dc->user_creatable = false;
>  }
>
>  static void shakti_c_soc_instance_init(Object *obj)


Otherwise,
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>