[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/1] vmx: Fix <genid/> mapping
|
From: |
Richard W.M. Jones |
|
Subject: |
Re: [PATCH 0/1] vmx: Fix <genid/> mapping |
|
Date: |
Wed, 29 Sep 2021 10:57:19 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Looking at the qemu code the problem IMHO is:
https://gitlab.com/qemu-project/qemu/-/blob/6b54a31bf7b403672a798b6443b1930ae6c74dea/docs/specs/vmgenid.txt#L189
https://gitlab.com/qemu-project/qemu/-/blob/6b54a31bf7b403672a798b6443b1930ae6c74dea/hw/acpi/vmgenid.c#L37
This byte swapping makes no sense to me. How do we know that the
guest is little endian? What will this code do for BE guests? I
think qemu would be better off treating the "GUID" as a list of bytes
and writing that exactly into the guest memory.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html
- Re: [PATCH 0/1] vmx: Fix <genid/> mapping, Richard W.M. Jones, 2021/09/29
- Re: [PATCH 0/1] vmx: Fix <genid/> mapping, Daniel P . Berrangé, 2021/09/29
- Re: [PATCH 0/1] vmx: Fix <genid/> mapping,
Richard W.M. Jones <=
- Re: [PATCH 0/1] vmx: Fix <genid/> mapping, Daniel P . Berrangé, 2021/09/29
- Re: [PATCH 0/1] vmx: Fix <genid/> mapping, Richard W.M. Jones, 2021/09/29
- Re: [PATCH 0/1] vmx: Fix <genid/> mapping, Richard W.M. Jones, 2021/09/30
- Re: [PATCH 0/1] vmx: Fix <genid/> mapping, Laszlo Ersek, 2021/09/30
- Re: [PATCH 0/1] vmx: Fix <genid/> mapping, Daniel P . Berrangé, 2021/09/30
- Re: [PATCH 0/1] vmx: Fix <genid/> mapping, Richard W.M. Jones, 2021/09/30