[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 03/13] qapi/parser: fix unused check_args_section arguments
From: |
John Snow |
Subject: |
[PATCH v4 03/13] qapi/parser: fix unused check_args_section arguments |
Date: |
Thu, 30 Sep 2021 16:57:06 -0400 |
Pylint informs us we're not using these arguments. Oops, it's
right. Correct the error message and remove the remaining unused
parameter.
Fix test output now that the error message is improved.
Fixes: e151941d1b
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/parser.py | 16 +++++++++-------
tests/qapi-schema/doc-bad-feature.err | 2 +-
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index f03ba2cfec8..bfd2dbfd9a2 100644
--- a/scripts/qapi/parser.py
+++ b/scripts/qapi/parser.py
@@ -753,16 +753,18 @@ def check_expr(self, expr):
def check(self):
- def check_args_section(args, info, what):
+ def check_args_section(args, what):
bogus = [name for name, section in args.items()
if not section.member]
if bogus:
raise QAPISemError(
self.info,
- "documented member%s '%s' %s not exist"
- % ("s" if len(bogus) > 1 else "",
- "', '".join(bogus),
- "do" if len(bogus) > 1 else "does"))
+ "documented %s%s '%s' %s not exist" % (
+ what,
+ "s" if len(bogus) > 1 else "",
+ "', '".join(bogus),
+ "do" if len(bogus) > 1 else "does"
+ ))
- check_args_section(self.args, self.info, 'members')
- check_args_section(self.features, self.info, 'features')
+ check_args_section(self.args, 'member')
+ check_args_section(self.features, 'feature')
diff --git a/tests/qapi-schema/doc-bad-feature.err
b/tests/qapi-schema/doc-bad-feature.err
index e4c62adfa3e..49d1746c3d1 100644
--- a/tests/qapi-schema/doc-bad-feature.err
+++ b/tests/qapi-schema/doc-bad-feature.err
@@ -1 +1 @@
-doc-bad-feature.json:3: documented member 'a' does not exist
+doc-bad-feature.json:3: documented feature 'a' does not exist
--
2.31.1
- [PATCH v4 00/13] qapi: static typing conversion, pt5b, John Snow, 2021/09/30
- [PATCH v4 01/13] qapi/pylintrc: ignore 'consider-using-f-string' warning, John Snow, 2021/09/30
- [PATCH v4 02/13] qapi/gen: use dict.items() to iterate over _modules, John Snow, 2021/09/30
- [PATCH v4 04/13] qapi: Add spaces after symbol declaration for consistency, John Snow, 2021/09/30
- [PATCH v4 05/13] qapi/parser: remove FIXME comment from _append_body_line, John Snow, 2021/09/30
- [PATCH v4 03/13] qapi/parser: fix unused check_args_section arguments,
John Snow <=
- [PATCH v4 06/13] qapi/parser: clarify _end_section() logic, John Snow, 2021/09/30
- [PATCH v4 07/13] qapi/parser: Introduce NullSection, John Snow, 2021/09/30
- [PATCH v4 08/13] qapi/parser: add import cycle workaround, John Snow, 2021/09/30
- [PATCH v4 11/13] qapi/parser: enable mypy checks, John Snow, 2021/09/30
- [PATCH v4 10/13] qapi/parser: Add FIXME for consolidating JSON-related types, John Snow, 2021/09/30
- [PATCH v4 12/13] qapi/parser: Silence too-few-public-methods warning, John Snow, 2021/09/30
- [PATCH v4 13/13] qapi/parser: enable pylint checks, John Snow, 2021/09/30
- [PATCH v4 09/13] qapi/parser: add type hint annotations (QAPIDoc), John Snow, 2021/09/30