[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 10/13] qapi/parser: Add FIXME for consolidating JSON-related t
|
From: |
John Snow |
|
Subject: |
[PATCH v4 10/13] qapi/parser: Add FIXME for consolidating JSON-related types |
|
Date: |
Thu, 30 Sep 2021 16:57:13 -0400 |
The fix for this comment is forthcoming in a future commit, but this
will keep me honest. The linting configuration in ./python/setup.cfg
prohibits 'FIXME' comments. A goal of this long-running series is to
move ./scripts/qapi to ./python/qemu/qapi so that the QAPI generator is
regularly type-checked by GitLab CI.
This comment is a time-bomb to force me to address this issue prior to
that step.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/parser.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index 73c1c4ef599..0265b47b955 100644
--- a/scripts/qapi/parser.py
+++ b/scripts/qapi/parser.py
@@ -43,6 +43,10 @@
# Return value alias for get_expr().
_ExprValue = Union[List[object], Dict[str, object], str, bool]
+# FIXME: Consolidate and centralize definitions for TopLevelExpr,
+# _ExprValue, _JSONValue, and _JSONObject; currently scattered across
+# several modules.
+
class QAPIParseError(QAPISourceError):
"""Error class for all QAPI schema parsing errors."""
--
2.31.1
- [PATCH v4 00/13] qapi: static typing conversion, pt5b, John Snow, 2021/09/30
- [PATCH v4 01/13] qapi/pylintrc: ignore 'consider-using-f-string' warning, John Snow, 2021/09/30
- [PATCH v4 02/13] qapi/gen: use dict.items() to iterate over _modules, John Snow, 2021/09/30
- [PATCH v4 04/13] qapi: Add spaces after symbol declaration for consistency, John Snow, 2021/09/30
- [PATCH v4 05/13] qapi/parser: remove FIXME comment from _append_body_line, John Snow, 2021/09/30
- [PATCH v4 03/13] qapi/parser: fix unused check_args_section arguments, John Snow, 2021/09/30
- [PATCH v4 06/13] qapi/parser: clarify _end_section() logic, John Snow, 2021/09/30
- [PATCH v4 07/13] qapi/parser: Introduce NullSection, John Snow, 2021/09/30
- [PATCH v4 08/13] qapi/parser: add import cycle workaround, John Snow, 2021/09/30
- [PATCH v4 11/13] qapi/parser: enable mypy checks, John Snow, 2021/09/30
- [PATCH v4 10/13] qapi/parser: Add FIXME for consolidating JSON-related types,
John Snow <=
- [PATCH v4 12/13] qapi/parser: Silence too-few-public-methods warning, John Snow, 2021/09/30
- [PATCH v4 13/13] qapi/parser: enable pylint checks, John Snow, 2021/09/30
- [PATCH v4 09/13] qapi/parser: add type hint annotations (QAPIDoc), John Snow, 2021/09/30