qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/9] replay: notify vCPU when BH is scheduled


From: Pavel Dovgalyuk
Subject: Re: [PATCH 2/9] replay: notify vCPU when BH is scheduled
Date: Wed, 4 May 2022 09:54:20 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0

On 26.04.2022 21:45, Richard Henderson wrote:
On 4/22/22 04:53, Pavel Dovgalyuk wrote:
+void icount_notify_exit(void)
+{
+    if (icount_enabled() && first_cpu) {
+        cpu_exit(first_cpu);
+        qemu_clock_notify(QEMU_CLOCK_VIRTUAL);
+    }
+}

Why first_cpu?  Did you really want to continue to the end of the round-robin?
Otherwise I'd expect qemu_cpu_kick(current_cpu), or something.

Looks reasonable, thank you.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]