[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v4 30/36] hw/i386: add eoi_intercept_unsupported member to X8
From: |
Xiaoyao Li |
Subject: |
[RFC PATCH v4 30/36] hw/i386: add eoi_intercept_unsupported member to X86MachineState |
Date: |
Thu, 12 May 2022 11:17:57 +0800 |
Add a new bool member, eoi_intercept_unsupported, to X86MachineState
with default value false. Set true for TDX VM.
Inability to intercept eoi causes impossibility to emulate level
triggered interrupt to be re-injected when level is still kept active.
which affects interrupt controller emulation.
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
hw/i386/x86.c | 1 +
include/hw/i386/x86.h | 1 +
target/i386/kvm/tdx.c | 2 ++
3 files changed, 4 insertions(+)
diff --git a/hw/i386/x86.c b/hw/i386/x86.c
index 17f2252296c5..182ec544611b 100644
--- a/hw/i386/x86.c
+++ b/hw/i386/x86.c
@@ -1365,6 +1365,7 @@ static void x86_machine_initfn(Object *obj)
x86ms->oem_id = g_strndup(ACPI_BUILD_APPNAME6, 6);
x86ms->oem_table_id = g_strndup(ACPI_BUILD_APPNAME8, 8);
x86ms->bus_lock_ratelimit = 0;
+ x86ms->eoi_intercept_unsupported = false;
}
static void x86_machine_class_init(ObjectClass *oc, void *data)
diff --git a/include/hw/i386/x86.h b/include/hw/i386/x86.h
index 9089bdd99c3a..5bf91dd934db 100644
--- a/include/hw/i386/x86.h
+++ b/include/hw/i386/x86.h
@@ -58,6 +58,7 @@ struct X86MachineState {
/* CPU and apic information: */
bool apic_xrupt_override;
+ bool eoi_intercept_unsupported;
unsigned pci_irq_mask;
unsigned apic_id_limit;
uint16_t boot_cpus;
diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c
index 59c7aa8f1818..583fda52de5f 100644
--- a/target/i386/kvm/tdx.c
+++ b/target/i386/kvm/tdx.c
@@ -340,6 +340,8 @@ int tdx_kvm_init(MachineState *ms, Error **errp)
return -EINVAL;
}
+ x86ms->eoi_intercept_unsupported = true;
+
if (!tdx_caps) {
get_tdx_capabilities();
}
--
2.27.0
- Re: [RFC PATCH v4 24/36] i386/tdx: Add TDVF memory via KVM_TDX_INIT_MEM_REGION, (continued)
- [RFC PATCH v4 25/36] i386/tdx: Call KVM_TDX_INIT_VCPU to initialize TDX vcpu, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 23/36] i386/tdx: Setup the TD HOB list, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 27/36] i386/tdx: Disable SMM for TDX VMs, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 29/36] i386/tdx: Don't allow system reset for TDX VMs, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 30/36] hw/i386: add eoi_intercept_unsupported member to X86MachineState,
Xiaoyao Li <=
- [RFC PATCH v4 26/36] i386/tdx: Finalize TDX VM, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 28/36] i386/tdx: Disable PIC for TDX VMs, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 33/36] i386/tdx: Only configure MSR_IA32_UCODE_REV in kvm_init_msrs() for TDs, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 35/36] i386/tdx: Don't get/put guest state for TDX VMs, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 32/36] i386/tdx: Don't synchronize guest tsc for TDs, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 34/36] i386/tdx: Skip kvm_put_apicbase() for TDs, Xiaoyao Li, 2022/05/11