[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v4 28/36] i386/tdx: Disable PIC for TDX VMs
From: |
Xiaoyao Li |
Subject: |
[RFC PATCH v4 28/36] i386/tdx: Disable PIC for TDX VMs |
Date: |
Thu, 12 May 2022 11:17:55 +0800 |
Legacy PIC (8259) cannot be supported for TDX VMs since TDX module
doesn't allow directly interrupt injection. Using posted interrupts
for the PIC is not a viable option as the guest BIOS/kernel will not
do EOI for PIC IRQs, i.e. will leave the vIRR bit set.
Hence disable PIC for TDX VMs and error out if user wants PIC.
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
target/i386/kvm/tdx.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c
index 7ff4c6a9a7ca..59c7aa8f1818 100644
--- a/target/i386/kvm/tdx.c
+++ b/target/i386/kvm/tdx.c
@@ -333,6 +333,13 @@ int tdx_kvm_init(MachineState *ms, Error **errp)
return -EINVAL;
}
+ if (x86ms->pic == ON_OFF_AUTO_AUTO) {
+ x86ms->pic = ON_OFF_AUTO_OFF;
+ } else if (x86ms->pic == ON_OFF_AUTO_ON) {
+ error_setg(errp, "TDX VM doesn't support PIC");
+ return -EINVAL;
+ }
+
if (!tdx_caps) {
get_tdx_capabilities();
}
--
2.27.0
- [RFC PATCH v4 23/36] i386/tdx: Setup the TD HOB list, (continued)
- [RFC PATCH v4 23/36] i386/tdx: Setup the TD HOB list, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 27/36] i386/tdx: Disable SMM for TDX VMs, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 29/36] i386/tdx: Don't allow system reset for TDX VMs, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 30/36] hw/i386: add eoi_intercept_unsupported member to X86MachineState, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 26/36] i386/tdx: Finalize TDX VM, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 28/36] i386/tdx: Disable PIC for TDX VMs,
Xiaoyao Li <=
- [RFC PATCH v4 33/36] i386/tdx: Only configure MSR_IA32_UCODE_REV in kvm_init_msrs() for TDs, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 35/36] i386/tdx: Don't get/put guest state for TDX VMs, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 32/36] i386/tdx: Don't synchronize guest tsc for TDs, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 34/36] i386/tdx: Skip kvm_put_apicbase() for TDs, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 31/36] hw/i386: add option to forcibly report edge trigger in acpi tables, Xiaoyao Li, 2022/05/11
- [RFC PATCH v4 36/36] docs: Add TDX documentation, Xiaoyao Li, 2022/05/11