Re: [PATCH v3 1/8] qmp: Support for querying stats

[Paolo Bonzini]

On 5/16/22 14:00, Markus Armbruster wrote:
> > +    StatsCallbacks *entry;
> > +
> > +    QTAILQ_FOREACH(entry, &stats_callbacks, next) {
> > +        entry->stats_cb(&stats_results, filter->target, errp);
> If more than one of these sets an error, then the second error_setg()
> will trip error_setv()'s assertion.
>
> What's the callback's contract?

I'll change it to free any partial results and return NULL on error. 
Same below.

> > +void add_stats_entry(StatsResultList **stats_results, StatsProvider provider,
> > +                     const char *qom_path, StatsList *stats_list)
> > +{
> > +    StatsResult *entry = g_new0(StatsResult, 1);
> Suggest blank line between declarations and statements, like in the next
> function.
>
> > +    entry->provider = provider;
> > +    if (qom_path) {
> > +        entry->has_qom_path = true;
> > +        entry->qom_path = g_strdup(qom_path);
> > +    }
> > +    entry->stats = stats_list;
> > +
> > +    QAPI_LIST_PREPEND(*stats_results, entry);
> > +}
> > +
> > +void add_stats_schema(StatsSchemaList **schema_results,
> > +                      StatsProvider provider, StatsTarget target,
> > +                      StatsSchemaValueList *stats_list)
> > +{
> > +    StatsSchema *entry = g_new0(StatsSchema, 1);
> > +
> > +    entry->provider = provider;
> > +    entry->target = target;
> > +    entry->stats = stats_list;
> > +    QAPI_LIST_PREPEND(*schema_results, entry);
> > +}
> The order of elements doesn't matter in either list, right?

Indeed it doesn't.

Paolo