[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/35] pc/q35: refactor ISA and SMBUS AML generation
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH 00/35] pc/q35: refactor ISA and SMBUS AML generation |
Date: |
Tue, 17 May 2022 10:17:52 +0200 |
On Mon, May 16, 2022 at 11:25:35AM -0400, Igor Mammedov wrote:
>
> Series is excerpt form larger refactoring that does
> the same for PCI devices, but it's too large at this
> point, so I've split off a relatively self-contained
> ISA/SMBUS patches into a smaller separate series, and
> PCI refactoring will follow up on top of this series
> using the same AcpiDevAmlIf interface.
>
> Series consolidates and unifies how pc/q35 machine
> generates AML for ISA and SMBUS devices. It adds
> a new more generic interface 'AcpiDevAmlIf' that
> replaces ISA specific ISADeviceClass::build_aml
> hook and should allow to use the same approach
> (i.e. ask a device to provide its own AML) but
> not limited to ISA bus.
> Series applies AcpiDevAmlIf interface to a few
> ISA devices that were already using
> ISADeviceClass::build_aml and to devices /tpm,
> applesmc,pvpanic,ipmi/ that were generated in
> custom way. The AML generation for the later
> class is normalized to behave like any other
> ISA device that were using ISADeviceClass::build_aml
> and converted to interface 'AcpiDevAmlIf'.
> It simplifies process of building DSDT and
> eliminates custom probing/wiring for those devices
> as AML for them is generated at the time ISA/SMBUS
> is enumerated.
>
> Changes to DSDT tables QEMU generates are mostly
> contextual where devices scattered across DSDT
> are consolidated under respective device that
> hosts bus they are attached to.
Promoting the ISADeviceClass::build_aml idea to a more general approach
certainly makes sense. ISA update is fine. Skimmed the other updates
too, looks all sane to me.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
- Re: [PATCH 30/35] tests: acpi: white-list DSDT.tis.tpm2/DSDT.tis.tpm12 expected blobs, (continued)
- [PATCH 32/35] acpi: pc/q35: remove not needed 'if' condition on pci bus, Igor Mammedov, 2022/05/16
- [PATCH 35/35] x86: acpi-build: do not include hw/isa/isa.h directly, Igor Mammedov, 2022/05/16
- [PATCH 34/35] tests: acpi: update expected DSDT.tis.tpm2/DSDT.tis.tpm12 blobs, Igor Mammedov, 2022/05/16
- [PATCH 33/35] acpi: tpm-tis: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML, Igor Mammedov, 2022/05/16
- Re: [PATCH 00/35] pc/q35: refactor ISA and SMBUS AML generation, Michael S. Tsirkin, 2022/05/16
- Re: [PATCH 00/35] pc/q35: refactor ISA and SMBUS AML generation,
Gerd Hoffmann <=