[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] ui: Remove deprecated parameters of the "-display sdl
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v2 1/3] ui: Remove deprecated parameters of the "-display sdl" option |
|
Date: |
Wed, 18 May 2022 17:04:05 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Thomas Huth <thuth@redhat.com> writes:
> These parameters are in the way for further refactoring (since they
> use an underscore in the name which is forbidden in QAPI), so let's
> remove these now that their deprecation period is over.
Forbidden, but there's an exception mechanism, so this reason isn't
compelling. I believe the actual reason is they are "too ugly and
inflexible to drag them along into the QAPI world" (your words).
Suggest:
Dropping these deprecated parameters now simplifies further
refactoring.
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Patch looks good to me, so
Reviewed-by: Markus Armbruster <armbru@redhat.com>
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, (continued)
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Thomas Huth, 2022/05/19
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Gerd Hoffmann, 2022/05/19
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Thomas Huth, 2022/05/19
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Gerd Hoffmann, 2022/05/19
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Markus Armbruster, 2022/05/19
Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Eric Blake, 2022/05/18
[PATCH v2 1/3] ui: Remove deprecated parameters of the "-display sdl" option, Thomas Huth, 2022/05/18
- Re: [PATCH v2 1/3] ui: Remove deprecated parameters of the "-display sdl" option,
Markus Armbruster <=
[PATCH v2 3/3] ui: Remove deprecated options "-sdl" and "-curses", Thomas Huth, 2022/05/18