[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser |
Date: |
Thu, 19 May 2022 12:48:24 +0200 |
Hi,
> Oh well, I just noticed that we already have a GrabToggleKeys enum in
> qapi/common.json ... I wonder whether I should try to use that instead? It
> seems to be used in a slightly different context, though, if I get that
> right ...?
qemu/ui/input-linux.c
Those switch the input routing between host and guest, and they act on
their own (i.e. by default both control keys without anything else).
For SDL it defines the modifiers to press in addition to the hotkeys
(i.e. ctrl + shift + 'G' for grab release, IIRC there a are more, 'F'
for fullscreen?).
So I don't think it makes sense to merge them.
take care,
Gerd
- [PATCH v2 0/3] ui: Remove deprecated sdl parameters and switch to QAPI parser, Thomas Huth, 2022/05/18
- [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Thomas Huth, 2022/05/18
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Markus Armbruster, 2022/05/18
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Thomas Huth, 2022/05/19
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Thomas Huth, 2022/05/19
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Thomas Huth, 2022/05/19
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Daniel P . Berrangé, 2022/05/19
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Markus Armbruster, 2022/05/19
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Thomas Huth, 2022/05/19
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Thomas Huth, 2022/05/19
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser,
Gerd Hoffmann <=
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Thomas Huth, 2022/05/19
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Gerd Hoffmann, 2022/05/19
- Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Markus Armbruster, 2022/05/19
Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser, Eric Blake, 2022/05/18
[PATCH v2 1/3] ui: Remove deprecated parameters of the "-display sdl" option, Thomas Huth, 2022/05/18
[PATCH v2 3/3] ui: Remove deprecated options "-sdl" and "-curses", Thomas Huth, 2022/05/18