[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05/15] osdep: export qemu_open_cloexec()
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 05/15] osdep: export qemu_open_cloexec() |
Date: |
Mon, 23 May 2022 13:29:51 +0100 |
On Fri, 13 May 2022 at 19:16, <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Used in the next patch, to simplify qga code.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> include/qemu/osdep.h | 1 +
> util/osdep.c | 10 ++++++++--
> 2 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index 67cc465416..64f51cfb7a 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -489,6 +489,7 @@ void sigaction_invoke(struct sigaction *action,
> */
> int qemu_open_old(const char *name, int flags, ...);
> int qemu_open(const char *name, int flags, Error **errp);
> +int qemu_open_cloexec(const char *name, int flags, mode_t mode, Error
> **errp);
> int qemu_create(const char *name, int flags, mode_t mode, Error **errp);
> int qemu_close(int fd);
> int qemu_unlink(const char *name);
Where we make a function global and put it in a header
we should generally add a documentation comment describing it,
please.
thanks
-- PMM
- [PATCH v3 00/15] Misc cleanups, marcandre . lureau, 2022/05/13
- [PATCH v3 01/15] include: move qemu_*_exec_dir() to cutils, marcandre . lureau, 2022/05/13
- [PATCH v3 02/15] util/win32: simplify qemu_get_local_state_dir(), marcandre . lureau, 2022/05/13
- [PATCH v3 03/15] tests: make libqmp buildable for win32, marcandre . lureau, 2022/05/13
- [PATCH v3 05/15] osdep: export qemu_open_cloexec(), marcandre . lureau, 2022/05/13
- Re: [PATCH v3 05/15] osdep: export qemu_open_cloexec(), Markus Armbruster, 2022/05/23
- Re: [PATCH v3 05/15] osdep: export qemu_open_cloexec(),
Peter Maydell <=
- Re: [PATCH v3 05/15] osdep: export qemu_open_cloexec(), Daniel P . Berrangé, 2022/05/23
- Re: [PATCH v3 05/15] osdep: export qemu_open_cloexec(), Marc-André Lureau, 2022/05/23
- Re: [PATCH v3 05/15] osdep: export qemu_open_cloexec(), Daniel P . Berrangé, 2022/05/23
- Re: [PATCH v3 05/15] osdep: export qemu_open_cloexec(), Marc-André Lureau, 2022/05/23
- Re: [PATCH v3 05/15] osdep: export qemu_open_cloexec(), Daniel P . Berrangé, 2022/05/23
- Re: [PATCH v3 05/15] osdep: export qemu_open_cloexec(), Marc-André Lureau, 2022/05/23
[PATCH v3 04/15] qga: flatten safe_open_or_create(), marcandre . lureau, 2022/05/13
[PATCH v3 06/15] qga: use qemu_open_cloexec() for safe_open_or_create(), marcandre . lureau, 2022/05/13