Re: [PATCH v3 17/49] semihosting: Use struct gdb_stat in common_semi_flen_cb

[Peter Maydell]

On Sat, 21 May 2022 at 01:04, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Use offsetof instead of an integer constant.
> Load the entire 64-bit size while we're at it.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  semihosting/arm-compat-semi.c | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)

Commit message seems to put the cart before the horse, in that
the important thing is the bugfix to read 64 bits and that
we choose to do that by using the struct offset is a detail :-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM