qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 21/49] semihosting: Use env more often in do_common_semiho


From: Peter Maydell
Subject: Re: [PATCH v3 21/49] semihosting: Use env more often in do_common_semihosting
Date: Mon, 23 May 2022 13:53:05 +0100

On Sat, 21 May 2022 at 01:04, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> We've already loaded cs->env_ptr into a local variable; use it.
> Since env is unconditionally used, we don't need a dummy use.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/common-semi-target.h   |  62 ++++++++++++++++++
>  target/riscv/common-semi-target.h |  50 +++++++++++++++
>  semihosting/arm-compat-semi.c     | 101 ++----------------------------
>  3 files changed, 116 insertions(+), 97 deletions(-)
>  create mode 100644 target/arm/common-semi-target.h
>  create mode 100644 target/riscv/common-semi-target.h

Commit message doesn't match contents -- two changes accidentally
squashed together here ?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]