[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 21/49] semihosting: Use env more often in do_common_semiho
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 21/49] semihosting: Use env more often in do_common_semihosting |
Date: |
Mon, 23 May 2022 13:53:05 +0100 |
On Sat, 21 May 2022 at 01:04, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> We've already loaded cs->env_ptr into a local variable; use it.
> Since env is unconditionally used, we don't need a dummy use.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/common-semi-target.h | 62 ++++++++++++++++++
> target/riscv/common-semi-target.h | 50 +++++++++++++++
> semihosting/arm-compat-semi.c | 101 ++----------------------------
> 3 files changed, 116 insertions(+), 97 deletions(-)
> create mode 100644 target/arm/common-semi-target.h
> create mode 100644 target/riscv/common-semi-target.h
Commit message doesn't match contents -- two changes accidentally
squashed together here ?
thanks
-- PMM
- [PATCH v3 30/49] semihosting: Split out semihost_sys_flen, (continued)
- [PATCH v3 30/49] semihosting: Split out semihost_sys_flen, Richard Henderson, 2022/05/20
- [PATCH v3 15/49] include/exec: Move gdb_stat and gdb_timeval to gdbstub.h, Richard Henderson, 2022/05/20
- [PATCH v3 37/49] semihosting: Fix docs comment for qemu_semihosting_console_inc, Richard Henderson, 2022/05/20
- [PATCH v3 29/49] semihosting: Split out semihost_sys_isatty, Richard Henderson, 2022/05/20
- [PATCH v3 31/49] semihosting: Split out semihost_sys_remove, Richard Henderson, 2022/05/20
- [PATCH v3 17/49] semihosting: Use struct gdb_stat in common_semi_flen_cb, Richard Henderson, 2022/05/20
- [PATCH v3 21/49] semihosting: Use env more often in do_common_semihosting, Richard Henderson, 2022/05/20
- Re: [PATCH v3 21/49] semihosting: Use env more often in do_common_semihosting,
Peter Maydell <=
- [PATCH v3 28/49] semihosting: Split out semihost_sys_lseek, Richard Henderson, 2022/05/20
- [PATCH v3 34/49] semihosting: Create semihost_sys_{stat,fstat}, Richard Henderson, 2022/05/20
- [PATCH v3 35/49] semihosting: Create semihost_sys_gettimeofday, Richard Henderson, 2022/05/20
- [PATCH v3 14/49] include/exec: Move gdb open flags to gdbstub.h, Richard Henderson, 2022/05/20
- [PATCH v3 20/49] semihosting: Split out common_semi_has_synccache, Richard Henderson, 2022/05/20
- [PATCH v3 19/49] semihosting: Split common_semi_flen_buf per target, Richard Henderson, 2022/05/20