Re: [PATCH 1/8] qmp: Support for querying stats

[Paolo Bonzini]

On 5/24/22 12:41, Markus Armbruster wrote:
> > +    return stats_results;
> > +}
> Have you considered making the callbacks return bool, following
> error.h's "Whenever practical, also return a value that indicates
> success / failure" recommendation?

No, because I generally do not consider that recommendation to apply to 
callbacks.

Callbacks are written many times and typically invoked just once, so I 
prefer an O(1) loss in convenience to an O(n) chance of making a mistake 
in the return value.

Paolo