Re: [PATCH 7/8] qmp: add filtering of statistics by name

[Paolo Bonzini]

On 5/24/22 15:08, Markus Armbruster wrote:
> > -typedef void SchemaRetrieveFunc(StatsSchemaList **result, Error **errp);
> > +                              strList *names, strList *targets, Error **errp);
> > +typedef void SchemaRetrieveFunc(StatsSchemaList **, Error **);
> Did you drop the parameter names intentionally? 

No, I didn't.

> > +                    /* No names allowed is the same as skipping the provider.  
> > */
>
> Long line.
>
> > +                    return false;
>
> Any other elements of filter->providers that match @provider will be
> silently ignored.  Is this what you want?

Hmm, key/value pairs are ugly in QMP.

I'll see if I can make it work nicely without inlining 
stats_provider_requested() in the caller.

> Uh, do we leak @p_names if earlier elements matched?

No, it's not copied so there are no leaks.