[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/17] hw/audio/ac97: Remove unimplemented reset functions
From: |
Paolo Bonzini |
Subject: |
[PULL 08/17] hw/audio/ac97: Remove unimplemented reset functions |
Date: |
Wed, 25 May 2022 21:28:43 +0200 |
From: BALATON Zoltan <balaton@eik.bme.hu>
The warm_reset() and cold_reset() functions are not implemented and do
nothing so no point in calling them or keep around as dead code.
Therefore remove them for now.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: VĂctor Colombo <victor.colombo@eldorado.org.br>
Message-Id:
<cc6e99fd498a9ae358ebce787fc04ab6e8201879.1650706617.git.balaton@eik.bme.hu>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/audio/ac97.c | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c
index 6b1c12bece..6584aa749e 100644
--- a/hw/audio/ac97.c
+++ b/hw/audio/ac97.c
@@ -222,16 +222,6 @@ static void po_callback(void *opaque, int free);
static void pi_callback(void *opaque, int avail);
static void mc_callback(void *opaque, int avail);
-static void warm_reset(AC97LinkState *s)
-{
- (void)s;
-}
-
-static void cold_reset(AC97LinkState *s)
-{
- (void)s;
-}
-
static void fetch_bd(AC97LinkState *s, AC97BusMasterRegs *r)
{
uint8_t b[8];
@@ -921,12 +911,7 @@ static void nabm_writel(void *opaque, uint32_t addr,
uint32_t val)
dolog("BDBAR[%d] <- 0x%x (bdbar 0x%x)\n", GET_BM(index), val,
r->bdbar);
break;
case GLOB_CNT:
- if (val & GC_WR) {
- warm_reset(s);
- }
- if (val & GC_CR) {
- cold_reset(s);
- }
+ /* TODO: Handle WR or CR being set (warm/cold reset requests) */
if (!(val & (GC_WR | GC_CR))) {
s->glob_cnt = val & GC_VALID_MASK;
}
--
2.36.1
- [PULL 00/17] Misc patches for 2022-05-25, Paolo Bonzini, 2022/05/25
- [PULL 01/17] target/i386: Remove LBREn bit check when access Arch LBR MSRs, Paolo Bonzini, 2022/05/25
- [PULL 02/17] hostmem: default the amount of prealloc-threads to smp-cpus, Paolo Bonzini, 2022/05/25
- [PULL 03/17] thread-pool: optimize scheduling of completion bottom half, Paolo Bonzini, 2022/05/25
- [PULL 04/17] thread-pool: replace semaphore with condition variable, Paolo Bonzini, 2022/05/25
- [PULL 05/17] thread-pool: remove stopping variable, Paolo Bonzini, 2022/05/25
- [PULL 06/17] contrib/elf2dmp: add ELF dump header checking, Paolo Bonzini, 2022/05/25
- [PULL 08/17] hw/audio/ac97: Remove unimplemented reset functions,
Paolo Bonzini <=
- [PULL 07/17] hw/audio/ac97: Coding style fixes to avoid checkpatch errors, Paolo Bonzini, 2022/05/25
- [PULL 09/17] hw/audio/ac97: Remove unneeded local variables, Paolo Bonzini, 2022/05/25
- [PULL 10/17] target/i386/kvm: Fix disabling MPX on "-cpu host" with MPX-capable host, Paolo Bonzini, 2022/05/25
- [PULL 11/17] ide_ioport_read: Return lower octet of data register instead of 0xFF, Paolo Bonzini, 2022/05/25
- [PULL 12/17] i386: Use hv_build_cpuid_leaf() for HV_CPUID_NESTED_FEATURES, Paolo Bonzini, 2022/05/25
- [PULL 14/17] i386: Hyper-V XMM fast hypercall input feature, Paolo Bonzini, 2022/05/25
- [PULL 15/17] i386: Hyper-V Support extended GVA ranges for TLB flush hypercalls, Paolo Bonzini, 2022/05/25
- [PULL 13/17] i386: Hyper-V Enlightened MSR bitmap feature, Paolo Bonzini, 2022/05/25
- [PULL 16/17] i386: Hyper-V Direct TLB flush hypercall, Paolo Bonzini, 2022/05/25
- [PULL 17/17] i386: docs: Convert hyperv.txt to rST, Paolo Bonzini, 2022/05/25