Re: [PATCH v3 4/9] replay: simplify async event processing

[Pavel Dovgalyuk]

On 26.05.2022 12:40, Paolo Bonzini wrote:
> On 5/26/22 10:45, Pavel Dovgalyuk wrote:
> > +
> > +typedef enum ReplayAsyncEventKind {
> > +    REPLAY_ASYNC_EVENT_BH,
> > +    REPLAY_ASYNC_EVENT_BH_ONESHOT,
> > +    REPLAY_ASYNC_EVENT_INPUT,
> > +    REPLAY_ASYNC_EVENT_INPUT_SYNC,
> > +    REPLAY_ASYNC_EVENT_CHAR_READ,
> > +    REPLAY_ASYNC_EVENT_BLOCK,
> > +    REPLAY_ASYNC_EVENT_NET,
> > +    REPLAY_ASYNC_COUNT
> > +} ReplayAsyncEventKind;
> > +
> >   /* Any changes to order/number of events will need to bump 
> > REPLAY_VERSION */
> >   enum ReplayEvents {
> >       /* for instruction event */
> > @@ -22,6 +35,7 @@ enum ReplayEvents {
> >       EVENT_EXCEPTION,
> >       /* for async events */
> >       EVENT_ASYNC,
> > +    EVENT_ASYNC_LAST = EVENT_ASYNC + REPLAY_ASYNC_COUNT - 1,
>
> Why not unify the two enums into one?

ReplayAsyncEventKind is used as a variable type.
I think narrow type describes the value better than common enum.

> Paolo