Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

[Marc-André Lureau]

Hi

On Fri, Aug 5, 2022 at 12:12 PM Markus Armbruster <armbru@redhat.com> wrote:

marcandre.lureau@redhat.com writes:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> This is just moving qapi-gen.py and related subdir to qemu-common, to
> ease review and proceed step by step. The following patches will move
> related necessary code, tests etc.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

As moved files tend to become low-level annoyances for a long time, I'd
like to understand why you want to move them.  The commit message says
"to ease review", which I suspect isn't the real reason.  Perhaps you
explained all that elsewhere already, but I missed it.

The end goal is to split some projects, such as qemu-ga, to standalone meson projects/subprojects. We will be able to build them independently from the rest of QEMU, and later on perhaps handle them outside of QEMU main repository. To achieve this, I first introduce a qemu-common subproject, where qapi and common units are provided. You can check https://gitlab.com/marcandre.lureau/qemu/-/commits/qga for a sneak peek at current end result.

I said "to ease review and proceed step by step" simply because there are no other changes: I don't move the rest of the qapi code & tests all together, it's in the subsequent series.

--

Marc-André Lureau