[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 11/15] qemu-common: move scripts/qapi
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 11/15] qemu-common: move scripts/qapi |
Date: |
Thu, 11 Aug 2022 13:46:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Peter Maydell <peter.maydell@linaro.org> writes:
> On Thu, 11 Aug 2022 at 11:09, Marc-André Lureau
> <marcandre.lureau@gmail.com> wrote:
>> On Thu, Aug 11, 2022 at 1:05 PM Markus Armbruster <armbru@redhat.com> wrote:
>>> Your moves tear closely related code apart. This is going to be a drag
>>> for developers in general and maintainers in particular.
>>>
>>> Ergonomics suffer when related code is in multiple places. Having to
>>> switch between directories and remember where is what will a constant
>>> low-level pain. Things that used to be simple & quick, like git-grep
>>> qapi/*.c, become more involved.
>>>
>>
>> It's inevitable when a project grows. QEMU is already a very large project.
>> Over the years, we have structured the project, by moving things and
>> splitting in subdirectories. Imho, this is actually helpful in many ways,
>> and we got used to it easily hopefully.
>
> I agree with this. But generally we've tried to do that by
> having the subdirectory splitting and naming match the
> structure of the codebase.
Good: move a bunch of closely related files from . (tree root) and
include/ to new ./whatever/ and include/whatever/. The improvement in
organization outweighs the pain of moving.
Not so good: split some files off ./whatever into ./else/where/, even
though they are closely related.
[...]
- Re: [PATCH v2 11/15] qemu-common: move scripts/qapi, (continued)
- Re: [PATCH v2 11/15] qemu-common: move scripts/qapi, Marc-André Lureau, 2022/08/05
- Re: [PATCH v2 11/15] qemu-common: move scripts/qapi, Markus Armbruster, 2022/08/11
- Re: [PATCH v2 11/15] qemu-common: move scripts/qapi, Marc-André Lureau, 2022/08/11
- Re: [PATCH v2 11/15] qemu-common: move scripts/qapi, Markus Armbruster, 2022/08/11
- Re: [PATCH v2 11/15] qemu-common: move scripts/qapi, Marc-André Lureau, 2022/08/11
- Re: [PATCH v2 11/15] qemu-common: move scripts/qapi, Peter Maydell, 2022/08/11
- Re: [PATCH v2 11/15] qemu-common: move scripts/qapi, Marc-André Lureau, 2022/08/11
- Re: [PATCH v2 11/15] qemu-common: move scripts/qapi, Daniel P . Berrangé, 2022/08/11
- Re: [PATCH v2 11/15] qemu-common: move scripts/qapi, Markus Armbruster, 2022/08/11
- Re: [PATCH v2 11/15] qemu-common: move scripts/qapi, Marc-André Lureau, 2022/08/22
- Re: [PATCH v2 11/15] qemu-common: move scripts/qapi,
Markus Armbruster <=