[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 03/12] migration: Export ram_transferred_ram()
From: |
Leonardo Brás |
Subject: |
Re: [PATCH v7 03/12] migration: Export ram_transferred_ram() |
Date: |
Thu, 11 Aug 2022 05:11:08 -0300 |
User-agent: |
Evolution 3.44.3 |
On Tue, 2022-08-02 at 08:38 +0200, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reviewed-by: David Edmondson <david.edmondson@oracle.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
Is this doubled Signed-off-by intentional?
> ---
> migration/ram.h | 2 ++
> migration/ram.c | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/migration/ram.h b/migration/ram.h
> index c7af65ac74..e844966f69 100644
> --- a/migration/ram.h
> +++ b/migration/ram.h
> @@ -65,6 +65,8 @@ int ram_load_postcopy(QEMUFile *f, int channel);
>
> void ram_handle_compressed(void *host, uint8_t ch, uint64_t size);
>
> +void ram_transferred_add(uint64_t bytes);
> +
> int ramblock_recv_bitmap_test(RAMBlock *rb, void *host_addr);
> bool ramblock_recv_bitmap_test_byte_offset(RAMBlock *rb, uint64_t
> byte_offset);
> void ramblock_recv_bitmap_set(RAMBlock *rb, void *host_addr);
> diff --git a/migration/ram.c b/migration/ram.c
> index b94669ba5d..85d89d61ac 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -422,7 +422,7 @@ uint64_t ram_bytes_remaining(void)
>
> MigrationStats ram_counters;
>
> -static void ram_transferred_add(uint64_t bytes)
> +void ram_transferred_add(uint64_t bytes)
> {
> if (runstate_is_running()) {
> ram_counters.precopy_bytes += bytes;
Other than that, FWIW:
Reviewed-by: Leonardo Bras <leobras@redhat.com>
Best regards,
Leo
- [PATCH v7 00/12] Migration: Transmit and detect zero pages in the multifd threads, Juan Quintela, 2022/08/02
- [PATCH v7 01/12] multifd: Create page_size fields into both MultiFD{Recv, Send}Params, Juan Quintela, 2022/08/02
- [PATCH v7 02/12] multifd: Create page_count fields into both MultiFD{Recv, Send}Params, Juan Quintela, 2022/08/02
- [PATCH v7 03/12] migration: Export ram_transferred_ram(), Juan Quintela, 2022/08/02
- Re: [PATCH v7 03/12] migration: Export ram_transferred_ram(),
Leonardo Brás <=
- [PATCH v7 07/12] multifd: Prepare to send a packet without the mutex held, Juan Quintela, 2022/08/02
- [PATCH v7 08/12] multifd: Add capability to enable/disable zero_page, Juan Quintela, 2022/08/02
- [PATCH v7 04/12] multifd: Count the number of bytes sent correctly, Juan Quintela, 2022/08/02