qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 8/8] accel/tcg: remove trace_vcpu_dstate TB checking


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v1 8/8] accel/tcg: remove trace_vcpu_dstate TB checking
Date: Fri, 12 Aug 2022 01:44:14 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0

On 11/8/22 17:14, Alex Bennée wrote:
We removed the ability to do vcpu tcg tracing between:

   d9a6bad542 (docs: remove references to TCG tracing)
   and
   126d4123c5 (tracing: excise the tcg related from tracetool)

but missed a bunch of other code. Lets continue the clean-up by
removing the extra field from tb_hash saving us 4 bytes per-TB and the
additional cost of hashing/checking something that was always empty
anyway.

There remain some per-vcpu trace points which don't look as though
they are called anywhere and the command line/QMP machinery to
clean-up.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
  accel/tcg/tb-hash.h       |  6 +++---
  include/exec/exec-all.h   |  3 ---
  accel/tcg/cpu-exec.c      |  6 +-----
  accel/tcg/translate-all.c | 13 ++-----------
  4 files changed, 6 insertions(+), 22 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]