[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 03/11] chardev/baum: Avoid dynamic stack allocation
From: |
Peter Maydell |
Subject: |
[PATCH v2 03/11] chardev/baum: Avoid dynamic stack allocation |
Date: |
Fri, 19 Aug 2022 16:39:23 +0100 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Use autofree heap allocation instead of variable-length
array on the stack.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
chardev/baum.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/chardev/baum.c b/chardev/baum.c
index 6a210ffd815..0a0d12661a4 100644
--- a/chardev/baum.c
+++ b/chardev/baum.c
@@ -299,7 +299,8 @@ static void baum_chr_accept_input(struct Chardev *chr)
static void baum_write_packet(BaumChardev *baum, const uint8_t *buf, int len)
{
Chardev *chr = CHARDEV(baum);
- uint8_t io_buf[1 + 2 * len], *cur = io_buf;
+ g_autofree uint8_t *io_buf = g_malloc(1 + 2 * len);
+ uint8_t *cur = io_buf;
int room;
*cur++ = ESC;
while (len--)
--
2.25.1
- [PATCH v2 00/11] misc: Remove variable-length arrays on the stack, Peter Maydell, 2022/08/19
- [PATCH v2 03/11] chardev/baum: Avoid dynamic stack allocation,
Peter Maydell <=
- [PATCH v2 04/11] io/channel-websock: Replace strlen(const_str) by sizeof(const_str) - 1, Peter Maydell, 2022/08/19
- [PATCH v2 02/11] chardev/baum: Use definitions to avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 01/11] chardev/baum: Replace magic values by X_MAX / Y_MAX definitions, Peter Maydell, 2022/08/19
- [PATCH v2 05/11] hw/net/e1000e_core: Use definition to avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 06/11] hw/ppc/pnv: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 07/11] hw/intc/xics: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 10/11] ui/curses: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 09/11] hw/usb/hcd-ohci: Use definition to avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 11/11] tests/unit/test-vmstate: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19