[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 01/11] chardev/baum: Replace magic values by X_MAX / Y_MAX def
From: |
Peter Maydell |
Subject: |
[PATCH v2 01/11] chardev/baum: Replace magic values by X_MAX / Y_MAX definitions |
Date: |
Fri, 19 Aug 2022 16:39:21 +0100 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Replace '84' magic value by the X_MAX definition, and '1' by Y_MAX.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
chardev/baum.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/chardev/baum.c b/chardev/baum.c
index 79d618e3504..6d538808a0f 100644
--- a/chardev/baum.c
+++ b/chardev/baum.c
@@ -87,6 +87,9 @@
#define BUF_SIZE 256
+#define X_MAX 84
+#define Y_MAX 1
+
struct BaumChardev {
Chardev parent;
@@ -244,11 +247,11 @@ static int baum_deferred_init(BaumChardev *baum)
brlapi_perror("baum: brlapi__getDisplaySize");
return 0;
}
- if (baum->y > 1) {
- baum->y = 1;
+ if (baum->y > Y_MAX) {
+ baum->y = Y_MAX;
}
- if (baum->x > 84) {
- baum->x = 84;
+ if (baum->x > X_MAX) {
+ baum->x = X_MAX;
}
con = qemu_console_lookup_by_index(0);
--
2.25.1
- [PATCH v2 00/11] misc: Remove variable-length arrays on the stack, Peter Maydell, 2022/08/19
- [PATCH v2 03/11] chardev/baum: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 04/11] io/channel-websock: Replace strlen(const_str) by sizeof(const_str) - 1, Peter Maydell, 2022/08/19
- [PATCH v2 02/11] chardev/baum: Use definitions to avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 01/11] chardev/baum: Replace magic values by X_MAX / Y_MAX definitions,
Peter Maydell <=
- [PATCH v2 05/11] hw/net/e1000e_core: Use definition to avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 06/11] hw/ppc/pnv: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 07/11] hw/intc/xics: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 10/11] ui/curses: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 09/11] hw/usb/hcd-ohci: Use definition to avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 11/11] tests/unit/test-vmstate: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- [PATCH v2 08/11] hw/i386/multiboot: Avoid dynamic stack allocation, Peter Maydell, 2022/08/19
- Re: [PATCH v2 00/11] misc: Remove variable-length arrays on the stack, Philippe Mathieu-Daudé, 2022/08/25