[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 45/51] tests/qtest: prom-env-test: Use double quotes to pass the
From: |
Bin Meng |
Subject: |
[PATCH 45/51] tests/qtest: prom-env-test: Use double quotes to pass the prom-env option |
Date: |
Wed, 24 Aug 2022 17:40:23 +0800 |
From: Bin Meng <bin.meng@windriver.com>
Single quotes like -prom-env 'nvramrc=cafec0de 4000 l!' in the arguments
are not removed in the Windows environment before it is passed to the
QEMU executable. Such argument causes a failure in the QEMU prom-env
option parser codes.
Change to use double quotes which works fine on all platforms.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---
tests/qtest/prom-env-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/prom-env-test.c b/tests/qtest/prom-env-test.c
index c2b0448e55..39ccb59797 100644
--- a/tests/qtest/prom-env-test.c
+++ b/tests/qtest/prom-env-test.c
@@ -58,8 +58,8 @@ static void test_machine(const void *machine)
" -machine " PSERIES_DEFAULT_CAPABILITIES;
}
- qts = qtest_initf("-M %s -accel tcg %s -prom-env 'use-nvramrc?=true' "
- "-prom-env 'nvramrc=%x %x l!' ", (const char *)machine,
+ qts = qtest_initf("-M %s -accel tcg %s -prom-env \"use-nvramrc?=true\" "
+ "-prom-env \"nvramrc=%x %x l!\" ", (const char *)machine,
extra_args, MAGIC, ADDRESS);
check_guest_memory(qts);
qtest_quit(qts);
--
2.34.1
- Re: [PATCH 38/51] tests/qtest: {ahci,ide}-test: Open file in binary mode, (continued)
- [PATCH 35/51] tests/qtest: device-plug-test: Reverse the usage of double/single quotes, Bin Meng, 2022/08/24
- [PATCH 37/51] tests/qtest: migration-test: Disable IO redirection for win32, Bin Meng, 2022/08/24
- [PATCH 42/51] hw/ppc: spapr: Use qemu_vfree() to free spapr->htab, Bin Meng, 2022/08/24
- [PATCH 41/51] tests/qtest: migration-test: Kill "to" after migration is canceled, Bin Meng, 2022/08/24
- [PATCH 45/51] tests/qtest: prom-env-test: Use double quotes to pass the prom-env option,
Bin Meng <=
- [PATCH 46/51] tests/qtest: libqtest: Replace the call to close a socket with closesocket(), Bin Meng, 2022/08/24
- [PATCH 36/51] tests/qtest: machine-none-test: Use double quotes to pass the cpu option, Bin Meng, 2022/08/24
- [PATCH 40/51] chardev/char-file: Add FILE_SHARE_WRITE when openning the file for win32, Bin Meng, 2022/08/24