qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 35/51] tests/qtest: device-plug-test: Reverse the usage of do


From: Thomas Huth
Subject: Re: [PATCH 35/51] tests/qtest: device-plug-test: Reverse the usage of double/single quotes
Date: Thu, 25 Aug 2022 14:20:13 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0

On 24/08/2022 11.40, Bin Meng wrote:
From: Bin Meng <bin.meng@windriver.com>

The usage of double/single quotes in test_pci_unplug_json_request()
should be reversed to work on both win32 and non-win32 platforms:

- The value of -device parameter needs to be surrounded by "" as
   Windows does not drop '' when passing it to QEMU which causes
   QEMU command line option parser failure.
- The JSON key/value pairs need to be surrounded by '' to make the
   JSON parser happy on Windows.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

  tests/qtest/device-plug-test.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c
index 2e3137843e..a1fb99c8ff 100644
--- a/tests/qtest/device-plug-test.c
+++ b/tests/qtest/device-plug-test.c
@@ -95,7 +95,7 @@ static void test_pci_unplug_json_request(void)
      }
QTestState *qtest = qtest_initf(
-        "%s -device '{\"driver\": \"virtio-mouse-pci\", \"id\": \"dev0\"}'",
+        "%s -device \"{'driver': 'virtio-mouse-pci', 'id': 'dev0'}\"",
          machine_addition);

It's also a shorter string, so that's even nicer to read!

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]