[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 07/10] hw/arm/virt: Fix devicetree warnings about node names
From: |
Jean-Philippe Brucker |
Subject: |
[PATCH 07/10] hw/arm/virt: Fix devicetree warnings about node names |
Date: |
Wed, 24 Aug 2022 16:51:11 +0100 |
dt-validate reports that several nodes have non-compliant names:
pl061@9030000: $nodename:0: 'pl061@9030000' does not match '^gpio@[0-9a-f]+$'
From schema: linux/Documentation/devicetree/bindings/gpio/pl061-gpio.yaml
pl031@9010000: $nodename:0: 'pl031@9010000' does not match
'^rtc(@.*|-[0-9a-f])*$'
From schema: linux/Documentation/devicetree/bindings/rtc/arm,pl031.yaml
pl011@9000000: $nodename:0: 'pl011@9000000' does not match '^serial(@.*)?$'
From schema: linux/Documentation/devicetree/bindings/serial/pl011.yaml
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
---
hw/arm/virt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 3d460f3686..952af37935 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -857,7 +857,7 @@ static void create_uart(const VirtMachineState *vms, int
uart,
sysbus_mmio_get_region(s, 0));
sysbus_connect_irq(s, 0, qdev_get_gpio_in(vms->gic, irq));
- nodename = g_strdup_printf("/pl011@%" PRIx64, base);
+ nodename = g_strdup_printf("/serial@%" PRIx64, base);
qemu_fdt_add_subnode(ms->fdt, nodename);
/* Note that we can't use setprop_string because of the embedded NUL */
qemu_fdt_setprop(ms->fdt, nodename, "compatible",
@@ -897,7 +897,7 @@ static void create_rtc(const VirtMachineState *vms)
sysbus_create_simple("pl031", base, qdev_get_gpio_in(vms->gic, irq));
- nodename = g_strdup_printf("/pl031@%" PRIx64, base);
+ nodename = g_strdup_printf("/rtc@%" PRIx64, base);
qemu_fdt_add_subnode(ms->fdt, nodename);
qemu_fdt_setprop(ms->fdt, nodename, "compatible", compat, sizeof(compat));
qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg",
@@ -999,7 +999,7 @@ static void create_gpio_devices(const VirtMachineState
*vms, int gpio,
sysbus_connect_irq(s, 0, qdev_get_gpio_in(vms->gic, irq));
uint32_t phandle = qemu_fdt_alloc_phandle(ms->fdt);
- nodename = g_strdup_printf("/pl061@%" PRIx64, base);
+ nodename = g_strdup_printf("/gpio@%" PRIx64, base);
qemu_fdt_add_subnode(ms->fdt, nodename);
qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg",
2, base, 2, size);
--
2.37.1
- [PATCH 00/10] hw/arm/virt: Fix dt-schema warnings, Jean-Philippe Brucker, 2022/08/24
- [PATCH 01/10] hw/arm/virt: Fix devicetree warning about the root node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 06/10] hw/arm/virt: Fix devicetree warning about the gpio-key node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 02/10] hw/arm/boot: Fix devicetree warning about the PSCI node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 07/10] hw/arm/virt: Fix devicetree warnings about node names,
Jean-Philippe Brucker <=
- [PATCH 03/10] hw/arm/virt: Fix devicetree warnings about the GIC node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 04/10] hw/arm/virt: Use "msi-map" devicetree property for PCI, Jean-Philippe Brucker, 2022/08/24
- [PATCH 05/10] hw/arm/virt: Fix devicetree warning about the timer node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 10/10] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 09/10] hw/arm/virt: Fix devicetree warnings about the SMMU node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 08/10] hw/arm/virt: Fix devicetree warnings about the GPIO node, Jean-Philippe Brucker, 2022/08/24