[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 04/10] hw/arm/virt: Use "msi-map" devicetree property for PCI
From: |
Jean-Philippe Brucker |
Subject: |
[PATCH 04/10] hw/arm/virt: Use "msi-map" devicetree property for PCI |
Date: |
Wed, 24 Aug 2022 16:51:08 +0100 |
The "msi-parent" property can be used on the PCI node when MSIs do not
contain sideband data (a device ID) [1]. In QEMU, MSI transactions
contain the requester ID, so the PCI node should use the "msi-map"
property instead of "msi-parent". In our case the property describes an
identity map between requester ID and sideband data.
This fixes a warning when passing the DTB generated by QEMU to dtc,
following a recent change to the GICv3 node:
Warning (msi_parent_property): /pcie@10000000:msi-parent: property size (4)
too small for cell size 1
[1] linux/Documentation/devicetree/bindings/pci/pci-msi.txt
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
---
hw/arm/virt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index b6aa311d8c..ca5d213895 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1489,8 +1489,8 @@ static void create_pcie(VirtMachineState *vms)
qemu_fdt_setprop(ms->fdt, nodename, "dma-coherent", NULL, 0);
if (vms->msi_phandle) {
- qemu_fdt_setprop_cells(ms->fdt, nodename, "msi-parent",
- vms->msi_phandle);
+ qemu_fdt_setprop_cells(ms->fdt, nodename, "msi-map",
+ 0, vms->msi_phandle, 0, 0x10000);
}
qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg",
--
2.37.1
- [PATCH 00/10] hw/arm/virt: Fix dt-schema warnings, Jean-Philippe Brucker, 2022/08/24
- [PATCH 01/10] hw/arm/virt: Fix devicetree warning about the root node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 06/10] hw/arm/virt: Fix devicetree warning about the gpio-key node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 02/10] hw/arm/boot: Fix devicetree warning about the PSCI node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 07/10] hw/arm/virt: Fix devicetree warnings about node names, Jean-Philippe Brucker, 2022/08/24
- [PATCH 03/10] hw/arm/virt: Fix devicetree warnings about the GIC node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 04/10] hw/arm/virt: Use "msi-map" devicetree property for PCI,
Jean-Philippe Brucker <=
- [PATCH 05/10] hw/arm/virt: Fix devicetree warning about the timer node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 10/10] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 09/10] hw/arm/virt: Fix devicetree warnings about the SMMU node, Jean-Philippe Brucker, 2022/08/24
- [PATCH 08/10] hw/arm/virt: Fix devicetree warnings about the GPIO node, Jean-Philippe Brucker, 2022/08/24