|
From: | Xiaoyao Li |
Subject: | Re: [PATCH v1 08/40] i386/tdx: Adjust the supported CPUID based on TDX restrictions |
Date: | Thu, 25 Aug 2022 20:44:39 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.12.0 |
On 8/25/2022 7:26 PM, Gerd Hoffmann wrote:
Hi,between VMM and TDs. Adjust supported CPUID for TDs based on TDX restrictions.Automatic adjustment depending on hardware capabilities isn't going to fly long-term, you'll run into compatibility problems sooner or later, for example when different hardware with diverging capabilities (first vs. second TDX generation) leads to different CPUID capsets in a otherwise identical configuration. Verification should happen of course, but I think qemu should just throw an error in case the tdx can't support a given cpu configuration.
I think you misunderstand this patch.It's to adjust the supported feature set of the platform, not the feature set of the given VM/TD. I.e, the adjusted supported feature set will be used to *verify* the VM's setting that specified by user. Of course, if user requires unsupported feature, QEMU will throw an error.
(see also Daniels reply to the cover letter). take care, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |