[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 03/16] qapi: fix example of query-spice command
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v1 03/16] qapi: fix example of query-spice command |
Date: |
Wed, 31 Aug 2022 13:50:31 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Victor Toso <victortoso@redhat.com> writes:
> Example output has an extra ',' delimiter and a foreign comment
> format. Fix it.
>
> Problem was noticed when trying to load the example into python's json
> library.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
> qapi/ui.json | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/qapi/ui.json b/qapi/ui.json
> index 286c5731d1..901b84da8a 100644
> --- a/qapi/ui.json
> +++ b/qapi/ui.json
> @@ -356,8 +356,7 @@
> # "host": "127.0.0.1",
> # "channel-id": 0,
> # "tls": false
> -# },
> -# [ ... more channels follow ... ]
> +# }
> # ]
> # }
> # }
Hmm. You're removing an ellipsis Gerd put there for a reason, I presume
(commit cb42a870c3 "spice: add qmp 'query-spice' and hmp 'info spice'
commands.")
Even if we can do without it here, We may still want a way to abridge
examples. Thoughts?
- [PATCH v1 00/16] qapi examples fixes and rfc for another generator, Victor Toso, 2022/08/30
- [PATCH v1 04/16] qapi: fix example of query-rocker-of-dpa-flows command, Victor Toso, 2022/08/30
- [PATCH v1 07/16] qapi: fix example of BLOCK_JOB_READY event, Victor Toso, 2022/08/30
- [PATCH v1 08/16] qapi: fix example of NIC_RX_FILTER_CHANGED event, Victor Toso, 2022/08/30
- [PATCH v1 09/16] qapi: fix example of DEVICE_UNPLUG_GUEST_ERROR event, Victor Toso, 2022/08/30
- [PATCH v1 06/16] qapi: fix example of query-blockstats command, Victor Toso, 2022/08/30
- [PATCH v1 11/16] qapi: fix examples of blockdev-add with qcow2, Victor Toso, 2022/08/30