[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 04/16] qapi: fix example of query-rocker-of-dpa-flows comm
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v1 04/16] qapi: fix example of query-rocker-of-dpa-flows command |
Date: |
Wed, 31 Aug 2022 13:51:01 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Victor Toso <victortoso@redhat.com> writes:
> Example output has an extra ',' delimiter and a foreign comment
> format. Fix it.
>
> Problem was noticed when trying to load the example into python's json
> library.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
> qapi/rocker.json | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/qapi/rocker.json b/qapi/rocker.json
> index b48e49a89b..6ae8689026 100644
> --- a/qapi/rocker.json
> +++ b/qapi/rocker.json
> @@ -251,8 +251,7 @@
> # "cookie": 0,
> # "action": {"goto-tbl": 10},
> # "mask": {"in-pport": 4294901760}
> -# },
> -# {...more...},
> +# }
> # ]}
> #
> ##
Review of previous patch applies.
- [PATCH v1 00/16] qapi examples fixes and rfc for another generator, Victor Toso, 2022/08/30
- [PATCH v1 05/16] qapi: fix example of query-dump-guest-memory-capability command, Victor Toso, 2022/08/30
- [PATCH v1 01/16] qapi: fix example of query-ballon command, Victor Toso, 2022/08/30
- [PATCH v1 02/16] qapi: fix example of query-vnc command, Victor Toso, 2022/08/30
- [PATCH v1 03/16] qapi: fix example of query-spice command, Victor Toso, 2022/08/30
- [PATCH v1 04/16] qapi: fix example of query-rocker-of-dpa-flows command, Victor Toso, 2022/08/30
- Re: [PATCH v1 04/16] qapi: fix example of query-rocker-of-dpa-flows command,
Markus Armbruster <=
- [PATCH v1 07/16] qapi: fix example of BLOCK_JOB_READY event, Victor Toso, 2022/08/30
- [PATCH v1 08/16] qapi: fix example of NIC_RX_FILTER_CHANGED event, Victor Toso, 2022/08/30
- [PATCH v1 09/16] qapi: fix example of DEVICE_UNPLUG_GUEST_ERROR event, Victor Toso, 2022/08/30
- [PATCH v1 06/16] qapi: fix example of query-blockstats command, Victor Toso, 2022/08/30
- [PATCH v1 11/16] qapi: fix examples of blockdev-add with qcow2, Victor Toso, 2022/08/30
- [PATCH v1 12/16] qapi: fix example of blockdev-add command, Victor Toso, 2022/08/30