[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 79/84] target/xtensa: Tidy translate_bb
From: |
Richard Henderson |
Subject: |
[PULL 79/84] target/xtensa: Tidy translate_bb |
Date: |
Sun, 5 Mar 2023 16:39:49 -0800 |
Replace ifdefs with C, tcg_const_i32 with tcg_constant_i32.
We only need a single temporary for this.
Reviewed-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/xtensa/translate.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 3ea50d8bc3..e3fcd50691 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
@@ -1406,19 +1406,15 @@ static void translate_b(DisasContext *dc, const
OpcodeArg arg[],
static void translate_bb(DisasContext *dc, const OpcodeArg arg[],
const uint32_t par[])
{
-#if TARGET_BIG_ENDIAN
- TCGv_i32 bit = tcg_const_i32(0x80000000u);
-#else
- TCGv_i32 bit = tcg_const_i32(0x00000001u);
-#endif
TCGv_i32 tmp = tcg_temp_new_i32();
+
tcg_gen_andi_i32(tmp, arg[1].in, 0x1f);
-#if TARGET_BIG_ENDIAN
- tcg_gen_shr_i32(bit, bit, tmp);
-#else
- tcg_gen_shl_i32(bit, bit, tmp);
-#endif
- tcg_gen_and_i32(tmp, arg[0].in, bit);
+ if (TARGET_BIG_ENDIAN) {
+ tcg_gen_shr_i32(tmp, tcg_constant_i32(0x80000000u), tmp);
+ } else {
+ tcg_gen_shl_i32(tmp, tcg_constant_i32(0x00000001u), tmp);
+ }
+ tcg_gen_and_i32(tmp, arg[0].in, tmp);
gen_brcondi(dc, par[0], tmp, 0, arg[2].imm);
}
--
2.34.1
- [PULL 76/84] target/riscv: Avoid tcg_const_*, (continued)
- [PULL 76/84] target/riscv: Avoid tcg_const_*, Richard Henderson, 2023/03/05
- [PULL 73/84] target/hexagon/idef-parser: Use gen_constant for gen_extend_tcg_width_op, Richard Henderson, 2023/03/05
- [PULL 66/84] include/exec/gen-icount: Drop tcg_temp_free in gen_tb_start, Richard Henderson, 2023/03/05
- [PULL 74/84] target/i386: Simplify POPF, Richard Henderson, 2023/03/05
- [PULL 78/84] target/sparc: Avoid tcg_const_{tl,i32}, Richard Henderson, 2023/03/05
- [PULL 77/84] target/s390x: Split out gen_ri2, Richard Henderson, 2023/03/05
- [PULL 75/84] target/microblaze: Avoid tcg_const_* throughout, Richard Henderson, 2023/03/05
- [PULL 53/84] target/rx: Drop tcg_temp_free, Richard Henderson, 2023/03/05
- [PULL 56/84] target/sparc: Drop get_temp_i32, Richard Henderson, 2023/03/05
- [PULL 70/84] target/hexagon/idef-parser: Use gen_tmp for LPCFG, Richard Henderson, 2023/03/05
- [PULL 79/84] target/xtensa: Tidy translate_bb,
Richard Henderson <=
- [PULL 80/84] target/xtensa: Tidy translate_clamps, Richard Henderson, 2023/03/05
- [PULL 83/84] target/xtensa: Split constant in bit shift, Richard Henderson, 2023/03/05
- [PULL 82/84] target/xtensa: Use tcg_gen_subfi_i32 in translate_sll, Richard Henderson, 2023/03/05
- [PULL 84/84] target/xtensa: Avoid tcg_const_i32, Richard Henderson, 2023/03/05
- [PULL 81/84] target/xtensa: Avoid tcg_const_i32 in translate_l32r, Richard Henderson, 2023/03/05
- Re: [PULL 00/84] tcg patch queue, Peter Maydell, 2023/03/06