[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] .editorconfig: set max line at 70 chars for QAPI files
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH] .editorconfig: set max line at 70 chars for QAPI files |
|
Date: |
Tue, 7 Mar 2023 12:40:22 +0000 |
|
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Tue, Mar 07, 2023 at 04:30:27PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> This seems to be the preferred style.
>
> The EditorConfig property is not supported by all editors:
> https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> .editorconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.editorconfig b/.editorconfig
> index 7303759ed7..8c5ebc6a1b 100644
> --- a/.editorconfig
> +++ b/.editorconfig
> @@ -47,3 +47,4 @@ emacs_mode = glsl
> [*.json]
> indent_style = space
> emacs_mode = python
> +max_line_length = 70
Why 70 as a hard limit ? I thought QEMU policy was that 80 was a soft
limit and we were happy with 90 if it avoided wrapping that would hurt
readability.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|