Re: [PATCH] .editorconfig: set max line at 70 chars for QAPI files

[Marc-André Lureau]

Hi

On Tue, Mar 7, 2023 at 4:41 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Tue, Mar 07, 2023 at 04:30:27PM +0400, marcandre.lureau@redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > This seems to be the preferred style.
> >
> > The EditorConfig property is not supported by all editors:
> > https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> >  .editorconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/.editorconfig b/.editorconfig
> > index 7303759ed7..8c5ebc6a1b 100644
> > --- a/.editorconfig
> > +++ b/.editorconfig
> > @@ -47,3 +47,4 @@ emacs_mode = glsl
> >  [*.json]
> >  indent_style = space
> >  emacs_mode = python
> > +max_line_length = 70
>
> Why 70 as a hard limit ?  I thought QEMU policy was that 80 was a soft
> limit and we were happy with 90 if it avoided wrapping that would hurt
> readability.

Markus regularly point out lines over 70 characters:
20230306122751.2355515-1-marcandre.lureau@redhat.com/20230306122751.2355515-9-marcandre.lureau@redhat.com/#871qm1j2zc.fsf@pond.sub.org">https://patchew.org/QEMU/20230306122751.2355515-1-marcandre.lureau@redhat.com/20230306122751.2355515-9-marcandre.lureau@redhat.com/#871qm1j2zc.fsf@pond.sub.org

(my default emacs config has fill-column 80, and I use fill-paragraph
- although sometime I may forget it)