[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 61/67] tcg/sparc: Avoid tcg_const_tl in gen_edge
From: |
Richard Henderson |
Subject: |
[PULL 61/67] tcg/sparc: Avoid tcg_const_tl in gen_edge |
Date: |
Tue, 7 Mar 2023 09:58:42 -0800 |
Push tcg_constant_tl into the shift argument directly.
Since t1 no longer exists as a temp, replace with lo1,
whose last use was just above.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/sparc/translate.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/target/sparc/translate.c b/target/sparc/translate.c
index 5ee293326c..137bdc5159 100644
--- a/target/sparc/translate.c
+++ b/target/sparc/translate.c
@@ -2838,7 +2838,7 @@ static inline void gen_load_trap_state_at_tl(TCGv_ptr
r_tsptr, TCGv_env cpu_env)
static void gen_edge(DisasContext *dc, TCGv dst, TCGv s1, TCGv s2,
int width, bool cc, bool left)
{
- TCGv lo1, lo2, t1, t2;
+ TCGv lo1, lo2;
uint64_t amask, tabl, tabr;
int shift, imask, omask;
@@ -2905,10 +2905,8 @@ static void gen_edge(DisasContext *dc, TCGv dst, TCGv
s1, TCGv s2,
tcg_gen_shli_tl(lo1, lo1, shift);
tcg_gen_shli_tl(lo2, lo2, shift);
- t1 = tcg_const_tl(tabl);
- t2 = tcg_const_tl(tabr);
- tcg_gen_shr_tl(lo1, t1, lo1);
- tcg_gen_shr_tl(lo2, t2, lo2);
+ tcg_gen_shr_tl(lo1, tcg_constant_tl(tabl), lo1);
+ tcg_gen_shr_tl(lo2, tcg_constant_tl(tabr), lo2);
tcg_gen_andi_tl(dst, lo1, omask);
tcg_gen_andi_tl(lo2, lo2, omask);
@@ -2927,9 +2925,9 @@ static void gen_edge(DisasContext *dc, TCGv dst, TCGv s1,
TCGv s2,
lo2 |= -(s1 == s2)
dst &= lo2
*/
- tcg_gen_setcond_tl(TCG_COND_EQ, t1, s1, s2);
- tcg_gen_neg_tl(t1, t1);
- tcg_gen_or_tl(lo2, lo2, t1);
+ tcg_gen_setcond_tl(TCG_COND_EQ, lo1, s1, s2);
+ tcg_gen_neg_tl(lo1, lo1);
+ tcg_gen_or_tl(lo2, lo2, lo1);
tcg_gen_and_tl(dst, dst, lo2);
}
--
2.34.1
- [PULL 55/67] target/rx: Use cpu_psw_z as temp in flags computation, (continued)
- [PULL 55/67] target/rx: Use cpu_psw_z as temp in flags computation, Richard Henderson, 2023/03/07
- [PULL 50/67] target/mips: Avoid tcg_const_tl in gen_r6_ld, Richard Henderson, 2023/03/07
- [PULL 54/67] target/rx: Use tcg_gen_abs_i32, Richard Henderson, 2023/03/07
- [PULL 56/67] target/rx: Avoid tcg_const_i32 when new temp needed, Richard Henderson, 2023/03/07
- [PULL 47/67] target/m68k: Avoid tcg_const_* throughout, Richard Henderson, 2023/03/07
- [PULL 57/67] target/rx: Avoid tcg_const_i32, Richard Henderson, 2023/03/07
- [PULL 59/67] target/sh4: Avoid tcg_const_i32 for TAS.B, Richard Henderson, 2023/03/07
- [PULL 60/67] target/sh4: Avoid tcg_const_i32, Richard Henderson, 2023/03/07
- [PULL 53/67] target/ppc: Avoid tcg_const_i64 in do_vector_shift_quad, Richard Henderson, 2023/03/07
- [PULL 58/67] target/s390x: Avoid tcg_const_i64, Richard Henderson, 2023/03/07
- [PULL 61/67] tcg/sparc: Avoid tcg_const_tl in gen_edge,
Richard Henderson <=
- [PULL 62/67] target/tricore: Split t_n as constant from temp as variable, Richard Henderson, 2023/03/07
- [PULL 64/67] target/tricore: Use setcondi instead of explicit allocation, Richard Henderson, 2023/03/07
- [PULL 65/67] target/tricore: Drop some temp initialization, Richard Henderson, 2023/03/07
- [PULL 66/67] target/tricore: Avoid tcg_const_i32, Richard Henderson, 2023/03/07
- [PULL 63/67] target/tricore: Rename t_off10 and use tcg_constant_i32, Richard Henderson, 2023/03/07
- [PULL 67/67] tcg: Replace tcg_const_i64 in tcg-op.c, Richard Henderson, 2023/03/07
- Re: [PULL 00/67] tcg patch queue, Peter Maydell, 2023/03/09