Re: [PATCH v2 00/18] ui: dbus & misc fixes

[Marc-André Lureau]

Hi

On Tue, Mar 7, 2023 at 3:57 PM <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Hi,
>
> This is a respin of a series I sent end of January that didn't get reviews, 
> here
> is your chance! :) A collection of fixes for UI related-stuff, and paving the
> way for accelerated/egl dbus display support on win32 (for 8.1 hopefully).
>
> I think they are worth including in 8.0, as little fixes and improvements. It
> would be nice to have included as early as rc0.

If there is nobody available/interested enough to review, I wonder if
I should use my ui/ maintainer hat and send a PR as is.

thanks

>
> v2:
> - add "ui/dbus: initialize cursor_fb"
> - add "ui/shader: fix #version directive must occur on first line"
> - add "ui/egl: print EGL error, helping debugging"
> - add "ui/sdl: add optional logging when _SDL_DEBUG is set"
> - add "ui/sdl: try to instantiate the matching opengl renderer"
> - add "ui: introduce egl_init()"
> - add "ui/dbus: do not require opengl & gbm"
> - add "ui/dbus: restrict opengl to gbm-enabled config"
> - drop "ui/dbus: update the display when switching surface", as I
>   am not yet confident enough about it
> - rebased
>
> Marc-André Lureau (18):
>   ui/dbus: initialize cursor_fb
>   ui/dbus: unregister clipboard on connection close
>   audio/dbus: there are no sender for p2p mode
>   ui/dbus: set mouse is-absolute during console creation
>   meson: ensure dbus-display generated code is built before other units
>   ui: rename cursor_{put->unref}
>   ui: rename cursor_{get->ref}, return it
>   ui: keep current cursor with QemuConsole
>   ui: set cursor upon listener registration
>   ui: set cursor position upon listener registration
>   ui/sdl: get the GL context from the window
>   ui/shader: fix #version directive must occur on first line
>   ui/egl: print EGL error, helping debugging
>   ui/sdl: add optional logging when _SDL_DEBUG is set
>   ui/sdl: try to instantiate the matching opengl renderer
>   ui: introduce egl_init()
>   ui/dbus: do not require opengl & gbm
>   ui/dbus: restrict opengl to gbm-enabled config
>
>  meson.build                      |  2 -
>  audio/audio_int.h                |  2 +-
>  include/ui/console.h             |  5 +-
>  include/ui/egl-helpers.h         |  4 ++
>  include/ui/sdl2.h                |  2 +
>  ui/vnc.h                         |  1 -
>  audio/dbusaudio.c                |  6 ++-
>  hw/display/qxl-render.c          |  4 +-
>  hw/display/qxl.c                 |  2 +-
>  hw/display/vmware_vga.c          |  4 +-
>  ui/console.c                     | 18 ++++++++
>  ui/cursor.c                      |  5 +-
>  ui/dbus-clipboard.c              | 18 +++-----
>  ui/dbus-console.c                | 13 ++++--
>  ui/dbus-listener.c               | 22 ++++++---
>  ui/dbus.c                        | 29 ++++++++----
>  ui/egl-headless.c                | 16 +++----
>  ui/egl-helpers.c                 | 79 +++++++++++++++++++++++++++++---
>  ui/sdl2.c                        | 17 ++++++-
>  ui/spice-core.c                  |  7 +--
>  ui/spice-display.c               |  8 ++--
>  ui/vnc.c                         |  8 +---
>  tests/qtest/meson.build          |  2 +-
>  ui/meson.build                   |  6 ++-
>  ui/shader/texture-blit-flip.vert |  1 -
>  ui/shader/texture-blit.frag      |  1 -
>  ui/shader/texture-blit.vert      |  1 -
>  27 files changed, 203 insertions(+), 80 deletions(-)
>
> --
> 2.39.2
>
>


-- 
Marc-André Lureau