[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC QEMU PATCH 08/18] virtio-gpu: Initialize Venus
From: |
Dmitry Osipenko |
Subject: |
Re: [RFC QEMU PATCH 08/18] virtio-gpu: Initialize Venus |
Date: |
Sun, 12 Mar 2023 20:51:03 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 |
On 3/12/23 12:22, Huang Rui wrote:
> From: Antonio Caggiano <antonio.caggiano@collabora.com>
>
> Request Venus when initializing VirGL.
>
> Signed-off-by: Antonio Caggiano <antonio.caggiano@collabora.com>
> ---
> hw/display/virtio-gpu-virgl.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c
> index fe03dc916f..f5ce206b93 100644
> --- a/hw/display/virtio-gpu-virgl.c
> +++ b/hw/display/virtio-gpu-virgl.c
> @@ -803,7 +803,11 @@ int virtio_gpu_virgl_init(VirtIOGPU *g)
> {
> int ret;
>
> +#ifdef VIRGL_RENDERER_VENUS
> + ret = virgl_renderer_init(g, VIRGL_RENDERER_VENUS, &virtio_gpu_3d_cbs);
> +#else
> ret = virgl_renderer_init(g, 0, &virtio_gpu_3d_cbs);
> +#endif
Note that Venus now requires VIRGL_RENDERER_RENDER_SERVER flag to be
set. Please test the patches with the latest virglrenderer and etc.
The #ifdef also doesn't allow adding new flags, it should look like:
#ifdef VIRGL_RENDERER_VENUS
flags |= VIRGL_RENDERER_RENDER_SERVER;
#endif
ret = virgl_renderer_init(g, flags, &virtio_gpu_3d_cbs);
--
Best regards,
Dmitry
- [RFC QEMU PATCH 01/18] virtio: Add shared memory capability, (continued)
- [RFC QEMU PATCH 01/18] virtio: Add shared memory capability, Huang Rui, 2023/03/12
- [RFC QEMU PATCH 02/18] virtio-gpu: hostmem, Huang Rui, 2023/03/12
- [RFC QEMU PATCH 03/18] virtio-gpu: Handle resource blob commands, Huang Rui, 2023/03/12
- [RFC QEMU PATCH 04/18] virtio-gpu: CONTEXT_INIT feature, Huang Rui, 2023/03/12
- [RFC QEMU PATCH 05/18] virtio-gpu: Unrealize, Huang Rui, 2023/03/12
- [RFC QEMU PATCH 06/18] virtio-gpu: Resource UUID, Huang Rui, 2023/03/12
- [RFC QEMU PATCH 07/18] virtio-gpu: Support Venus capset, Huang Rui, 2023/03/12
- [RFC QEMU PATCH 08/18] virtio-gpu: Initialize Venus, Huang Rui, 2023/03/12
[RFC QEMU PATCH 09/18] meson: Enable virglrenderer unstable APIs, Huang Rui, 2023/03/12
[RFC QEMU PATCH 10/18] virtio-gpu: Handle set scanout blob command, Huang Rui, 2023/03/12
[RFC QEMU PATCH 11/18] virtio-gpu: make blob scanout use dmabuf fd, Huang Rui, 2023/03/12
[RFC QEMU PATCH 12/18] softmmu: Fix the size to map cache with xen for host virtual address, Huang Rui, 2023/03/12