[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to
From: |
Jason Andryuk |
Subject: |
Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation |
Date: |
Sun, 12 Mar 2023 15:19:40 -0400 |
On Tue, Mar 7, 2023 at 1:29 PM David Woodhouse <dwmw2@infradead.org> wrote:
>
> From: Paul Durrant <pdurrant@amazon.com>
>
> Signed-off-by: Paul Durrant <pdurrant@amazon.com>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> Reviewed-by: Paul Durrant <paul@xen.org>
> ---
> accel/xen/xen-all.c | 11 +-
> hw/char/xen_console.c | 2 +-
> hw/i386/kvm/xen_xenstore.c | 3 -
> hw/i386/kvm/xenstore_impl.h | 8 +-
> hw/xen/xen-bus-helper.c | 62 +++----
> hw/xen/xen-bus.c | 261 ++++------------------------
> hw/xen/xen-legacy-backend.c | 119 +++++++------
> hw/xen/xen-operations.c | 198 +++++++++++++++++++++
> hw/xen/xen_devconfig.c | 4 +-
> hw/xen/xen_pt_graphics.c | 1 -
> hw/xen/xen_pvdev.c | 49 +-----
> include/hw/xen/xen-bus-helper.h | 26 +--
> include/hw/xen/xen-bus.h | 17 +-
> include/hw/xen/xen-legacy-backend.h | 6 +-
> include/hw/xen/xen_backend_ops.h | 163 +++++++++++++++++
> include/hw/xen/xen_common.h | 1 -
> include/hw/xen/xen_pvdev.h | 2 +-
> softmmu/globals.c | 1 +
> 18 files changed, 525 insertions(+), 409 deletions(-)
>
> diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c
> index e85e4aeba5..425216230f 100644
> --- a/accel/xen/xen-all.c
> +++ b/accel/xen/xen-all.c
> @@ -90,12 +90,15 @@ void xenstore_store_pv_console_info(int i, Chardev *chr)
> }
>
>
> -static void xenstore_record_dm_state(struct xs_handle *xs, const char *state)
> +static void xenstore_record_dm_state(const char *state)
> {
> + struct xs_handle *xs;
> char path[50];
>
> + /* We now have everything we need to set the xenstore entry. */
> + xs = xs_open(0);
> if (xs == NULL) {
> - error_report("xenstore connection not initialized");
> + fprintf(stderr, "Could not contact XenStore\n");
> exit(1);
> }
This breaks dm_restrict=1 since the xs_open is not allowed by the time
this is called. There are other evtchn errors before this as well:
# cat /var/log/xen/qemu-dm-debian.log
char device redirected to /dev/pts/8 (label serial0)
xen be core: can't open evtchn device
xen be core: can't open evtchn device
xen be core: can't open evtchn device
xen be core: can't open evtchn device
xen be core: can't open evtchn device
xen be core: can't open evtchn device
xen be core: can't open evtchn device
xen be core: can't open evtchn device
Could not contact XenStore
Ok, those "xen be core: can't open evtchn device" were there before
the recent changes and seem to be non-fatal.
Regards,
Jason
- [PULL 00/27] Enable PV backends with Xen/KVM emulation, David Woodhouse, 2023/03/07
- [PULL 22/27] hw/xen: Add emulated implementation of XenStore operations, David Woodhouse, 2023/03/07
- [PULL 01/27] hw/xen: Add xenstore wire implementation and implementation stubs, David Woodhouse, 2023/03/07
- [PULL 10/27] hw/xen: Add gnttab operations to allow redirection to internal emulation, David Woodhouse, 2023/03/07
- [PULL 05/27] hw/xen: Watches on XenStore transactions, David Woodhouse, 2023/03/07
- [PULL 02/27] hw/xen: Add basic XenStore tree walk and write/read/directory support, David Woodhouse, 2023/03/07
- [PULL 11/27] hw/xen: Pass grant ref to gnttab unmap operation, David Woodhouse, 2023/03/07
- [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation, David Woodhouse, 2023/03/07
- Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation,
Jason Andryuk <=
- Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation, David Woodhouse, 2023/03/13
- Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation, Jason Andryuk, 2023/03/13
- Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation, David Woodhouse, 2023/03/14
- [PATCH] accel/xen: Fix DM state change notification in dm_restrict mode, David Woodhouse, 2023/03/14
- Re: [PATCH] accel/xen: Fix DM state change notification in dm_restrict mode, Paul Durrant, 2023/03/14
- Re: [PATCH] accel/xen: Fix DM state change notification in dm_restrict mode, Jason Andryuk, 2023/03/14
[PULL 03/27] hw/xen: Implement XenStore watches, David Woodhouse, 2023/03/07
[PULL 09/27] hw/xen: Add evtchn operations to allow redirection to internal emulation, David Woodhouse, 2023/03/07
[PULL 20/27] hw/xen: Hook up emulated implementation for event channel operations, David Woodhouse, 2023/03/07
[PULL 19/27] hw/xen: Only advertise ring-page-order for xen-block if gnttab supports it, David Woodhouse, 2023/03/07