[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] accel/xen: Fix DM state change notification in dm_restrict m
From: |
Jason Andryuk |
Subject: |
Re: [PATCH] accel/xen: Fix DM state change notification in dm_restrict mode |
Date: |
Tue, 14 Mar 2023 06:49:34 -0400 |
On Tue, Mar 14, 2023 at 4:35 AM David Woodhouse <dwmw2@infradead.org> wrote:
>
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> When dm_restrict is set, QEMU isn't permitted to update the XenStore node
> to indicate its running status. Previously, the xs_write() call would fail
> but the failure was ignored.
>
> However, in refactoring to allow for emulated XenStore operations, a new
> call to xs_open() was added. That one didn't fail gracefully, causing a
> fatal error when running in dm_restrict mode.
>
> Partially revert the offending patch, removing the additional call to
> xs_open() because the global 'xenstore' variable is still available; it
> just needs to be used with qemu_xen_xs_write() now instead of directly
> with the xs_write() libxenstore function.
>
> Also make the whole thing conditional on !xen_domid_restrict. There's no
> point even registering the state change handler to attempt to update the
> XenStore node when we know it's destined to fail.
>
> Fixes: ba2a92db1ff6 ("hw/xen: Add xenstore operations to allow redirection to
> internal emulation")
> Reported-by: Jason Andryuk <jandryuk@gmail.com>
> Co-developed-by: Jason Andryuk <jandryuk@gmail.com>
> Not-Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> Will-be-Tested-by: Jason Andryuk <jandryuk@gmail.com>
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Tested-by: Jason Andryuk <jandryuk@gmail.com>
Thanks, David.
-Jason
- [PULL 05/27] hw/xen: Watches on XenStore transactions, (continued)
- [PULL 05/27] hw/xen: Watches on XenStore transactions, David Woodhouse, 2023/03/07
- [PULL 02/27] hw/xen: Add basic XenStore tree walk and write/read/directory support, David Woodhouse, 2023/03/07
- [PULL 11/27] hw/xen: Pass grant ref to gnttab unmap operation, David Woodhouse, 2023/03/07
- [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation, David Woodhouse, 2023/03/07
- Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation, Jason Andryuk, 2023/03/12
- Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation, David Woodhouse, 2023/03/13
- Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation, Jason Andryuk, 2023/03/13
- Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation, David Woodhouse, 2023/03/14
- [PATCH] accel/xen: Fix DM state change notification in dm_restrict mode, David Woodhouse, 2023/03/14
- Re: [PATCH] accel/xen: Fix DM state change notification in dm_restrict mode, Paul Durrant, 2023/03/14
- Re: [PATCH] accel/xen: Fix DM state change notification in dm_restrict mode,
Jason Andryuk <=
[PULL 03/27] hw/xen: Implement XenStore watches, David Woodhouse, 2023/03/07
[PULL 09/27] hw/xen: Add evtchn operations to allow redirection to internal emulation, David Woodhouse, 2023/03/07
[PULL 20/27] hw/xen: Hook up emulated implementation for event channel operations, David Woodhouse, 2023/03/07
[PULL 19/27] hw/xen: Only advertise ring-page-order for xen-block if gnttab supports it, David Woodhouse, 2023/03/07
[PULL 24/27] hw/xen: Implement soft reset for emulated gnttab, David Woodhouse, 2023/03/07
[PULL 07/27] hw/xen: Implement core serialize/deserialize methods for xenstore_impl, David Woodhouse, 2023/03/07
[PULL 15/27] hw/xen: Use XEN_PAGE_SIZE in PV backend drivers, David Woodhouse, 2023/03/07
[PULL 06/27] hw/xen: Implement XenStore permissions, David Woodhouse, 2023/03/07
[PULL 08/27] hw/xen: Create initial XenStore nodes, David Woodhouse, 2023/03/07
[PULL 14/27] hw/xen: Move xenstore_store_pv_console_info to xen_console.c, David Woodhouse, 2023/03/07