[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to
From: |
David Woodhouse |
Subject: |
Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation |
Date: |
Mon, 13 Mar 2023 08:45:26 +0000 |
User-agent: |
Evolution 3.44.4-0ubuntu1 |
On Sun, 2023-03-12 at 15:19 -0400, Jason Andryuk wrote:
>
> This breaks dm_restrict=1 since the xs_open is not allowed by the
> time
> this is called. There are other evtchn errors before this as well:
> # cat /var/log/xen/qemu-dm-debian.log
> char device redirected to /dev/pts/8 (label serial0)
> xen be core: can't open evtchn device
> xen be core: can't open evtchn device
> xen be core: can't open evtchn device
> xen be core: can't open evtchn device
> xen be core: can't open evtchn device
> xen be core: can't open evtchn device
> xen be core: can't open evtchn device
> xen be core: can't open evtchn device
> Could not contact XenStore
>
> Ok, those "xen be core: can't open evtchn device" were there before
> the recent changes and seem to be non-fatal.
Hm, I *think* we can just revert that part and use the global
'xenstore' like we did before, except via the new ops.
--- a/accel/xen/xen-all.c
+++ b/accel/xen/xen-all.c
@@ -32,28 +32,18 @@ xendevicemodel_handle *xen_dmod;
static void xenstore_record_dm_state(const char *state)
{
- struct xs_handle *xs;
char path[50];
- /* We now have everything we need to set the xenstore entry. */
- xs = xs_open(0);
- if (xs == NULL) {
- fprintf(stderr, "Could not contact XenStore\n");
- exit(1);
- }
-
snprintf(path, sizeof (path), "device-model/%u/state", xen_domid);
/*
* This call may fail when running restricted so don't make it fatal in
* that case. Toolstacks should instead use QMP to listen for state
changes.
*/
- if (!xs_write(xs, XBT_NULL, path, state, strlen(state)) &&
+ if (!qemu_xen_xs_write(xenstore, XBT_NULL, path, state, strlen(state)) &&
!xen_domid_restrict) {
error_report("error recording dm state");
exit(1);
}
-
- xs_close(xs);
}
Alternatively, that xs_write is destined to fail anyway in the
xen_domid_restrict case, isn't it? So the xs_open() should be allowed
to fail similarly. Or perhaps we shouldn't even *try*?
smime.p7s
Description: S/MIME cryptographic signature
- [PULL 00/27] Enable PV backends with Xen/KVM emulation, David Woodhouse, 2023/03/07
- [PULL 22/27] hw/xen: Add emulated implementation of XenStore operations, David Woodhouse, 2023/03/07
- [PULL 01/27] hw/xen: Add xenstore wire implementation and implementation stubs, David Woodhouse, 2023/03/07
- [PULL 10/27] hw/xen: Add gnttab operations to allow redirection to internal emulation, David Woodhouse, 2023/03/07
- [PULL 05/27] hw/xen: Watches on XenStore transactions, David Woodhouse, 2023/03/07
- [PULL 02/27] hw/xen: Add basic XenStore tree walk and write/read/directory support, David Woodhouse, 2023/03/07
- [PULL 11/27] hw/xen: Pass grant ref to gnttab unmap operation, David Woodhouse, 2023/03/07
- [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation, David Woodhouse, 2023/03/07
- Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation, Jason Andryuk, 2023/03/12
- Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation,
David Woodhouse <=
- Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation, Jason Andryuk, 2023/03/13
- Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation, David Woodhouse, 2023/03/14
- [PATCH] accel/xen: Fix DM state change notification in dm_restrict mode, David Woodhouse, 2023/03/14
- Re: [PATCH] accel/xen: Fix DM state change notification in dm_restrict mode, Paul Durrant, 2023/03/14
- Re: [PATCH] accel/xen: Fix DM state change notification in dm_restrict mode, Jason Andryuk, 2023/03/14
[PULL 03/27] hw/xen: Implement XenStore watches, David Woodhouse, 2023/03/07
[PULL 09/27] hw/xen: Add evtchn operations to allow redirection to internal emulation, David Woodhouse, 2023/03/07
[PULL 20/27] hw/xen: Hook up emulated implementation for event channel operations, David Woodhouse, 2023/03/07
[PULL 19/27] hw/xen: Only advertise ring-page-order for xen-block if gnttab supports it, David Woodhouse, 2023/03/07
[PULL 24/27] hw/xen: Implement soft reset for emulated gnttab, David Woodhouse, 2023/03/07