qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use f-strings in python scripts


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] Use f-strings in python scripts
Date: Wed, 15 Mar 2023 08:43:33 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

Hi Marco,

(+Python experts)

On 13/3/23 18:25, Marco Liebel wrote:
Replace python 2 format string with f-strings

Signed-off-by: Marco Liebel <quic_mliebel@quicinc.com>
---
  target/hexagon/gen_helper_funcs.py      |  54 ++--
  target/hexagon/gen_helper_protos.py     |  10 +-
  target/hexagon/gen_idef_parser_funcs.py |   8 +-
  target/hexagon/gen_op_attribs.py        |   4 +-
  target/hexagon/gen_op_regs.py           |  10 +-
  target/hexagon/gen_opcodes_def.py       |   2 +-
  target/hexagon/gen_printinsn.py         |  14 +-
  target/hexagon/gen_shortcode.py         |   2 +-
  target/hexagon/gen_tcg_func_table.py    |   2 +-
  target/hexagon/gen_tcg_funcs.py         | 317 +++++++++++-------------
  target/hexagon/hex_common.py            |   4 +-
  11 files changed, 198 insertions(+), 229 deletions(-)

These files use a mix of ', " and '''... Since you are modifying
them, it would be nice to unify. I'm not sure there is a recommended
style; matter of taste, I find the single quote (') less aggressive,
then escaping it using ", and keeping ''' for multi-lines strings.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]