Re: [PATCH] Use f-strings in python scripts

[Philippe Mathieu-Daudé]

On 15/3/23 12:16, Daniel P. Berrangé wrote:
> On Wed, Mar 15, 2023 at 08:43:33AM +0100, Philippe Mathieu-Daudé wrote:
> > Hi Marco,
> >
> > (+Python experts)
> >
> > On 13/3/23 18:25, Marco Liebel wrote:
> > > Replace python 2 format string with f-strings
> > >
> > > Signed-off-by: Marco Liebel <quic_mliebel@quicinc.com>
> > > ---
> > >    target/hexagon/gen_helper_funcs.py      |  54 ++--
> > >    target/hexagon/gen_helper_protos.py     |  10 +-
> > >    target/hexagon/gen_idef_parser_funcs.py |   8 +-
> > >    target/hexagon/gen_op_attribs.py        |   4 +-
> > >    target/hexagon/gen_op_regs.py           |  10 +-
> > >    target/hexagon/gen_opcodes_def.py       |   2 +-
> > >    target/hexagon/gen_printinsn.py         |  14 +-
> > >    target/hexagon/gen_shortcode.py         |   2 +-
> > >    target/hexagon/gen_tcg_func_table.py    |   2 +-
> > >    target/hexagon/gen_tcg_funcs.py         | 317 +++++++++++-------------
> > >    target/hexagon/hex_common.py            |   4 +-
> > >    11 files changed, 198 insertions(+), 229 deletions(-)
> >
> > These files use a mix of ', " and '''... Since you are modifying
> > them, it would be nice to unify. I'm not sure there is a recommended
> > style; matter of taste, I find the single quote (') less aggressive,
> > then escaping it using ", and keeping ''' for multi-lines strings.
>
> FWIW, rather than debating code style issues and coming up with a custom
> set of rules for QEMU python code, my recommendation would be to consider
> adopting 'black'
>
>    https://black.readthedocs.io/en/stable/
>
> There is a trend with recent languages to offer an opinionated code
> formatting tool as standard to maximise consistency across projects
> in a given language. 'black' is a decent attempt to bring this to
> the python world. I found it pretty liberating when doing recent
> python work in libvirt, to be able to mostly not worry about formatting
> anymore.

Clever.

So per 'black -t py37' the style is """, I was not even close.

> The main downside is the bulk-reformat in the history, which can
> make backports more challenging. For "git blame" you can use the
> .git-blame-ignore-revs file to hide the reformats.

TIL .git-blame-ignore-revs, thanks!