[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/14] tests/qapi-schema: Clean up positive test for conditio
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 11/14] tests/qapi-schema: Clean up positive test for conditionals |
|
Date: |
Fri, 17 Mar 2023 07:29:24 -0500 |
|
User-agent: |
NeoMutt/20220429 |
On Fri, Mar 17, 2023 at 07:10:52AM +0100, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
>
> > On Thu, Mar 16, 2023 at 08:13:22AM +0100, Markus Armbruster wrote:
> >> Union TestIfUnion is conditional on macros TEST_IF_UNION and
> >> TEST_IF_STRUCT. It uses TestIfEnum, which is conditional on macro
> >> TEST_IF_ENUM. If TEST_IF_ENUM and TEST_IF_STRUCT are defined, but
> >> TEST_IF_ENUM isn't, the generated code won't compile.
> >
> > s/ENUM/UNION/ in one of these two uses in this sentence.
>
> Yes: If TEST_IF_UNION and TEST_IF_UNION are defined, ...
If TEST_IF_UNION and TEST_IF_STRUCT are defined, ...
(you are stuck in a maze of twisty little passages, all alike)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[PATCH 05/14] qapi: Improve error message for unexpected array types, Markus Armbruster, 2023/03/16
[PATCH 02/14] qapi/schema: Use super(), Markus Armbruster, 2023/03/16
[PATCH 01/14] qapi: Fix error message format regression, Markus Armbruster, 2023/03/16
[PATCH 08/14] qapi: Fix to reject 'data': 'mumble' in struct, Markus Armbruster, 2023/03/16