[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/14] tests/qapi-schema: Clean up positive test for conditio
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 11/14] tests/qapi-schema: Clean up positive test for conditionals |
|
Date: |
Fri, 17 Mar 2023 15:14:23 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Eric Blake <eblake@redhat.com> writes:
> On Fri, Mar 17, 2023 at 07:10:52AM +0100, Markus Armbruster wrote:
>> Eric Blake <eblake@redhat.com> writes:
>>
>> > On Thu, Mar 16, 2023 at 08:13:22AM +0100, Markus Armbruster wrote:
>> >> Union TestIfUnion is conditional on macros TEST_IF_UNION and
>> >> TEST_IF_STRUCT. It uses TestIfEnum, which is conditional on macro
>> >> TEST_IF_ENUM. If TEST_IF_ENUM and TEST_IF_STRUCT are defined, but
>> >> TEST_IF_ENUM isn't, the generated code won't compile.
>> >
>> > s/ENUM/UNION/ in one of these two uses in this sentence.
>>
>> Yes: If TEST_IF_UNION and TEST_IF_UNION are defined, ...
>
> If TEST_IF_UNION and TEST_IF_STRUCT are defined, ...
>
> (you are stuck in a maze of twisty little passages, all alike)
I am!
Thanks :)
[PATCH 05/14] qapi: Improve error message for unexpected array types, Markus Armbruster, 2023/03/16
[PATCH 02/14] qapi/schema: Use super(), Markus Armbruster, 2023/03/16
[PATCH 01/14] qapi: Fix error message format regression, Markus Armbruster, 2023/03/16
[PATCH 08/14] qapi: Fix to reject 'data': 'mumble' in struct, Markus Armbruster, 2023/03/16
[PATCH 12/14] tests/qapi-schema: Cover optional conditional struct member, Markus Armbruster, 2023/03/16