[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qtests: avoid printing comments before g_test_init()
|
From: |
Alex Bennée |
|
Subject: |
Re: [PATCH] qtests: avoid printing comments before g_test_init() |
|
Date: |
Fri, 17 Mar 2023 17:28:04 +0000 |
|
User-agent: |
mu4e 1.9.22; emacs 29.0.60 |
Daniel P. Berrangé <berrange@redhat.com> writes:
> The TAP protocol version line must be the first thing printed on
> stdout. The migration test failed that requirement in certain
> scenarios:
>
> # Skipping test: Userfault not available (builtdtime)
> TAP version 13
> # random seed: R02Sc120c807f11053eb90bfea845ba1e368
> 1..32
> # Start of x86_64 tests
> # Start of migration tests
> ....
>
> The TAP version is printed by g_test_init(), so we need to make
> sure that any methods which print are run after that.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Queued to pr/170323-for-8.0-1, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro